[ 
https://issues.apache.org/jira/browse/HBASE-20269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16412295#comment-16412295
 ] 

Ted Yu commented on HBASE-20269:
--------------------------------

The check doesn't have to be added - without it, the ZKUtil.multiOrSequential 
is a NoOp if the list is empty.

> ZKReplicationQueueStorage#setWALPosition should only call 
> ZKUtil#multiOrSequential when there is at least one ZKUtilOp
> ----------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-20269
>                 URL: https://issues.apache.org/jira/browse/HBASE-20269
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>            Priority: Major
>         Attachments: 20269.v1.txt
>
>
> In ZKReplicationQueueStorage#setWALPosition :
> {code}
>       addLastSeqIdsToOps(queueId, lastSeqIds, listOfOps);
>       ZKUtil.multiOrSequential(zookeeper, listOfOps, false);
> {code}
> If there is no ZKUtilOp in listOfOps, the call to ZKUtil#multiOrSequential 
> should be skipped.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to