[ https://issues.apache.org/jira/browse/HBASE-20227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16412395#comment-16412395 ]
Hadoop QA commented on HBASE-20227: ----------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 17s{color} | {color:blue} Docker mode activated. {color} | | {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 2s{color} | {color:red} HBASE-20227 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/0.7.0/precommit-patchnames for help. {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 | | JIRA Issue | HBASE-20227 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12916027/HBASE-20227.master.003.patch | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/12117/console | | Powered by | Apache Yetus 0.7.0 http://yetus.apache.org | This message was automatically generated. > Add UT for ReplicationUtils.contains method > ------------------------------------------- > > Key: HBASE-20227 > URL: https://issues.apache.org/jira/browse/HBASE-20227 > Project: HBase > Issue Type: Sub-task > Components: Replication > Reporter: Duo Zhang > Assignee: Jingyun Tian > Priority: Major > Fix For: 3.0.0 > > Attachments: HBASE-20227.master.001.patch, > HBASE-20227.master.002.patch, HBASE-20227.master.003.patch > > > The method is extracted from NamespaceTableCfWALEntryFilter. But > NamespaceTableCfWALEntryFilter is in the hbase-server module so the UTs which > tests the function of this method are also in the hbase-server module. If > later we modify ReplicationUtils.contains without touching any code in > hbase-server, then we will not run the UTs for this method and may introduce > bugs. -- This message was sent by Atlassian JIRA (v7.6.3#76005)