[
https://issues.apache.org/jira/browse/HBASE-5241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Phabricator updated HBASE-5241:
-------------------------------
Attachment: HBASE-5241.D1731.1.patch
aaiyer requested code review of "HBASE-5241 [jira] Deletes should not mask Puts
that come after it.".
Reviewers: JIRA
https://issues.apache.org/jira/browse/HBASE-5241
[HBASE-5241] Puts should not be masked by prior Deletes
Initial version of the patch. Getting it out to start
discussion/get feedback on a few different ways to address this.
There are test failures.
Suppose that we have a delete row, and then followed by the put. The delete
row
can mask the put, unless there was a major compaction in between.
Now that we are flushing the memstoreTS to disk, along with the KVs, we
should be able
to differentiate whether or not the Put happened after the Delete and offer
better
delete semantics.
Couldn't find a pre-existing JIRA that already discusses this, so creating
one.
Seems related to https://issues.apache.org/jira/browse/HBASE-2406, but is not
quite the same.
TEST PLAN
EMPTY
REVISION DETAIL
https://reviews.facebook.net/D1731
AFFECTED FILES
src/test/java/org/apache/hadoop/hbase/regionserver/TestScanDeleteTracker.java
src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
src/test/java/org/apache/hadoop/hbase/regionserver/TestCompaction.java
src/main/java/org/apache/hadoop/hbase/HConstants.java
src/main/java/org/apache/hadoop/hbase/regionserver/ScanQueryMatcher.java
src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileScanner.java
src/main/java/org/apache/hadoop/hbase/regionserver/DeleteTracker.java
src/main/java/org/apache/hadoop/hbase/regionserver/ScanDeleteTracker.java
src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/3687/
Tip: use the X-Herald-Rules header to filter Herald messages in your client.
> Deletes should not mask Puts that come after it.
> ------------------------------------------------
>
> Key: HBASE-5241
> URL: https://issues.apache.org/jira/browse/HBASE-5241
> Project: HBase
> Issue Type: Improvement
> Reporter: Amitanand Aiyer
> Attachments: HBASE-5241.D1731.1.patch
>
>
> Suppose that we have a delete row, and then followed by the put. The delete
> row
> can mask the put, unless there was a major compaction in between.
> Now that we are flushing the memstoreTS to disk, along with the KVs, we
> should be able
> to differentiate whether or not the Put happened after the Delete and offer
> better
> delete semantics.
> Couldn't find a pre-existing JIRA that already discusses this, so creating
> one.
> Seems related to https://issues.apache.org/jira/browse/HBASE-2406, but is not
> quite the same.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
