[
https://issues.apache.org/jira/browse/HBASE-20229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16415203#comment-16415203
]
Hadoop QA commented on HBASE-20229:
-----------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
42s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
2s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} branch-1 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
14s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
49s{color} | {color:green} branch-1 passed {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
9s{color} | {color:red} hbase-client in branch-1 failed with JDK v1.8.0_163.
{color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
15s{color} | {color:red} hbase-server in branch-1 failed with JDK v1.8.0_163.
{color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
11s{color} | {color:red} hbase-client in branch-1 failed with JDK v1.7.0_171.
{color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
17s{color} | {color:red} hbase-server in branch-1 failed with JDK v1.7.0_171.
{color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
55s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
3s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
56s{color} | {color:green} branch-1 passed with JDK v1.8.0_163 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
7s{color} | {color:green} branch-1 passed with JDK v1.7.0_171 {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
15s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
53s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
10s{color} | {color:red} hbase-client in the patch failed with JDK v1.8.0_163.
{color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
20s{color} | {color:red} hbase-server in the patch failed with JDK v1.8.0_163.
{color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 10s{color}
| {color:red} hbase-client in the patch failed with JDK v1.8.0_163. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 20s{color}
| {color:red} hbase-server in the patch failed with JDK v1.8.0_163. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
12s{color} | {color:red} hbase-client in the patch failed with JDK v1.7.0_171.
{color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
22s{color} | {color:red} hbase-server in the patch failed with JDK v1.7.0_171.
{color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 12s{color}
| {color:red} hbase-client in the patch failed with JDK v1.7.0_171. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 22s{color}
| {color:red} hbase-server in the patch failed with JDK v1.7.0_171. {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
36s{color} | {color:green} The patch hbase-client passed checkstyle {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
29s{color} | {color:green} hbase-server: The patch generated 0 new + 0
unchanged - 1 fixed = 0 total (was 1) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 2m
47s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 3m
49s{color} | {color:red} The patch causes 44 errors with Hadoop v2.4.1. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 4m
53s{color} | {color:red} The patch causes 44 errors with Hadoop v2.5.2. {color}
|
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
47s{color} | {color:green} the patch passed with JDK v1.8.0_163 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
1s{color} | {color:green} the patch passed with JDK v1.7.0_171 {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
28s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}115m 7s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
37s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}145m 18s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests |
hadoop.hbase.replication.regionserver.TestGlobalThrottler |
| | hadoop.hbase.master.TestMasterMetrics |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:36a7029 |
| JIRA Issue | HBASE-20229 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12916338/HBASE-20229.branch-1.002.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 0966bf14b1d8 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9
14:43:09 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | branch-1 / caf4c4b |
| maven | version: Apache Maven 3.0.5 |
| Default Java | 1.7.0_171 |
| Multi-JDK versions | /usr/lib/jvm/java-8-openjdk-amd64:1.8.0_163
/usr/lib/jvm/java-7-openjdk-amd64:1.7.0_171 |
| compile |
https://builds.apache.org/job/PreCommit-HBASE-Build/12163/artifact/patchprocess/branch-compile-hbase-client-jdk1.8.0_163.txt
|
| compile |
https://builds.apache.org/job/PreCommit-HBASE-Build/12163/artifact/patchprocess/branch-compile-hbase-server-jdk1.8.0_163.txt
|
| compile |
https://builds.apache.org/job/PreCommit-HBASE-Build/12163/artifact/patchprocess/branch-compile-hbase-client-jdk1.7.0_171.txt
|
| compile |
https://builds.apache.org/job/PreCommit-HBASE-Build/12163/artifact/patchprocess/branch-compile-hbase-server-jdk1.7.0_171.txt
|
| compile |
https://builds.apache.org/job/PreCommit-HBASE-Build/12163/artifact/patchprocess/patch-compile-hbase-client-jdk1.8.0_163.txt
|
| compile |
https://builds.apache.org/job/PreCommit-HBASE-Build/12163/artifact/patchprocess/patch-compile-hbase-server-jdk1.8.0_163.txt
|
| javac |
https://builds.apache.org/job/PreCommit-HBASE-Build/12163/artifact/patchprocess/patch-compile-hbase-client-jdk1.8.0_163.txt
|
| javac |
https://builds.apache.org/job/PreCommit-HBASE-Build/12163/artifact/patchprocess/patch-compile-hbase-server-jdk1.8.0_163.txt
|
| compile |
https://builds.apache.org/job/PreCommit-HBASE-Build/12163/artifact/patchprocess/patch-compile-hbase-client-jdk1.7.0_171.txt
|
| compile |
https://builds.apache.org/job/PreCommit-HBASE-Build/12163/artifact/patchprocess/patch-compile-hbase-server-jdk1.7.0_171.txt
|
| javac |
https://builds.apache.org/job/PreCommit-HBASE-Build/12163/artifact/patchprocess/patch-compile-hbase-client-jdk1.7.0_171.txt
|
| javac |
https://builds.apache.org/job/PreCommit-HBASE-Build/12163/artifact/patchprocess/patch-compile-hbase-server-jdk1.7.0_171.txt
|
| hadoopcheck |
https://builds.apache.org/job/PreCommit-HBASE-Build/12163/artifact/patchprocess/patch-javac-2.4.1.txt
|
| hadoopcheck |
https://builds.apache.org/job/PreCommit-HBASE-Build/12163/artifact/patchprocess/patch-javac-2.5.2.txt
|
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/12163/artifact/patchprocess/patch-unit-hbase-server.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/12163/testReport/ |
| Max. process+thread count | 4052 (vs. ulimit of 10000) |
| modules | C: hbase-client hbase-server U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/12163/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> ConnectionImplementation.locateRegions() returns duplicated entries when
> region replication is on
> -------------------------------------------------------------------------------------------------
>
> Key: HBASE-20229
> URL: https://issues.apache.org/jira/browse/HBASE-20229
> Project: HBase
> Issue Type: Bug
> Reporter: Toshihiro Suzuki
> Assignee: Toshihiro Suzuki
> Priority: Major
> Fix For: 2.0.0
>
> Attachments: HBASE-20229.branch-1.001.patch,
> HBASE-20229.branch-1.002.patch, HBASE-20229.master.001.patch,
> HBASE-20229.master.002.patch, HBASE-20229.master.003.patch,
> HBASE-20229.master.004.patch
>
>
> The issue is when region replication is on,
> ConnectionImplementation.locateRegions() returns duplicated entries.
> In the test in my patch, the table should have 1 primary region + 2
> secondaries, but ConnectionImplementation.locateRegions() returns 9 regions.
> Every region repeats 3 times (3 = replicas count).
> I think this is because the following code calls locateRegion() even for
> replica regions and then the result triples.
> {code:java}
> for (RegionInfo regionInfo : regions) {
> RegionLocations list = locateRegion(tableName,
> regionInfo.getStartKey(), useCache, true);
> if (list != null) {
> for (HRegionLocation loc : list.getRegionLocations()) {
> if (loc != null) {
> locations.add(loc);
> }
> }
> }
> {code}
> The fix in my patch is to make it call locateRegion() only for a primary
> region.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
