[
https://issues.apache.org/jira/browse/HBASE-5396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208239#comment-13208239
]
stack commented on HBASE-5396:
------------------------------
On the below:
{code}
+ public boolean isRegionOnline(HRegionInfo hri) {
+ HServerInfo hsi = this.regions.get(hri);
+ if (hsi != null && this.isServerOnline(hsi.getServerName())) {
+ return true;
+ }
+ return false;
+ }
{code}
Don't you have to take out a lock on this.regions before you access it? See
the comment in this.servers.
Also, could write the end of the method so:
{code}
return hsi != null && this.isServerOnline(hsi.getServerName();
{code}
Whats a RegionsWithDeadServer? Is it RegionsOnDeadServers?
The below is called regionplan but its storing HRegionInfos?
{code}
+ Set<HRegionInfo> regionPlanOnThisServer = new HashSet<HRegionInfo>();
{code}
And then here, we are storing a Set of HRIs but method name talks of
RegionPlans. Its a little hard to follow?
Ditto here:
{code}
+ private Set<HRegionInfo> regionPlanOnThisServer = null;
{code}
and this...
{code}
+ public Set<HRegionInfo> getRegionPlanOnThisServer() {
{code}
This comment doesn't seem right?
{code}
+ * Process result used by processServerShutdown.
{code}
There is no processing done in this data structure.
... and save a few lines?
> Handle the regions in regionPlans while processing ServerShutdownHandler
> ------------------------------------------------------------------------
>
> Key: HBASE-5396
> URL: https://issues.apache.org/jira/browse/HBASE-5396
> Project: HBase
> Issue Type: Bug
> Components: master
> Affects Versions: 0.90.6
> Reporter: Jieshan Bean
> Assignee: Jieshan Bean
> Fix For: 0.90.7
>
> Attachments: HBASE-5396-90.patch
>
>
> The regions plan to open on this server while ServerShutdownHandler is
> handling, just be removed from AM.regionPlans, and only left to
> TimeoutMonitor handle these regions. This need to optimize.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
