[
https://issues.apache.org/jira/browse/HBASE-3134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208412#comment-13208412
]
[email protected] commented on HBASE-3134:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3686/
-----------------------------------------------------------
(Updated 2012-02-15 12:17:50.909795)
Review request for hbase.
Changes
-------
- PeerStateTracker is moved to ReplicationPeer
- ReplicationSource.sourceEnabled is removed
(Each ReplicationSource checks what's in ZK through ReplicationZookeeper)
- Existence of peer state zk nodes is checked and the zk node would be created
if it does not exist.
However, ReplicationZookeeper is still not thread safe.
Summary
-------
1. The patch introduces a znode which represents whether a peer is enabled or
not. ReplicationSource skips sending entries if the replication is disabled.
2. The "list_peers" shows state of each peer and support for
{enable|disable}Peer is added.
This addresses bug HBASE-3134.
https://issues.apache.org/jira/browse/HBASE-3134
Diffs (updated)
-----
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/replication/ReplicationAdmin.java
1244330
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeer.java
1244330
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/replication/ReplicationZookeeper.java
1244330
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
1244330
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceInterface.java
1244330
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java
1244330
http://svn.apache.org/repos/asf/hbase/trunk/src/main/ruby/hbase/replication_admin.rb
1244330
http://svn.apache.org/repos/asf/hbase/trunk/src/main/ruby/shell/commands/list_peers.rb
1244330
http://svn.apache.org/repos/asf/hbase/trunk/src/test/java/org/apache/hadoop/hbase/replication/ReplicationSourceDummy.java
1244330
http://svn.apache.org/repos/asf/hbase/trunk/src/test/java/org/apache/hadoop/hbase/replication/TestReplication.java
1244330
http://svn.apache.org/repos/asf/hbase/trunk/src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestReplicationSourceManager.java
1244330
Diff: https://reviews.apache.org/r/3686/diff
Testing
-------
1. TestReplication passed.
2. Checked on a cluster with some updates (puts) from shell.
Thanks,
Teruyoshi
> [replication] Add the ability to enable/disable streams
> -------------------------------------------------------
>
> Key: HBASE-3134
> URL: https://issues.apache.org/jira/browse/HBASE-3134
> Project: HBase
> Issue Type: New Feature
> Components: replication
> Reporter: Jean-Daniel Cryans
> Assignee: Teruyoshi Zenmyo
> Priority: Minor
> Labels: replication
> Fix For: 0.94.0
>
> Attachments: 3134-v2.txt, 3134.txt, HBASE-3134.patch,
> HBASE-3134.patch, HBASE-3134.patch, HBASE-3134.patch
>
>
> This jira was initially in the scope of HBASE-2201, but was pushed out since
> it has low value compared to the required effort (and when want to ship
> 0.90.0 rather soonish).
> We need to design a way to enable/disable replication streams in a
> determinate fashion.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
