[
https://issues.apache.org/jira/browse/HBASE-19389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16420450#comment-16420450
]
Chance Li commented on HBASE-19389:
-----------------------------------
[~stack] Thanks for advice, boss。
{quote}Should we not rather not keep counters unless trace is enabled?
{quote}
To make counters right, it can't be trigged by enabling trace. but maybe we can
optimize to reduce a comparison:
{code:java}
int currentConcurrency = this.currentParallelPutCount.getAndIncrement();
if (LOG.isTraceEnabled()) {
if (currentConcurrency > this.parallelPutCountPrintThreshold) {
LOG.trace("....");
}
}
{code}
{quote}Is this how you folks used it?
{quote}
Yes, We need this logs to quickly figure out what happened, sometimes it's not
even the user wanted .
> Limit concurrency of put with dense (hundreds) columns to prevent write
> handler exhausted
> -----------------------------------------------------------------------------------------
>
> Key: HBASE-19389
> URL: https://issues.apache.org/jira/browse/HBASE-19389
> Project: HBase
> Issue Type: Improvement
> Components: Performance
> Affects Versions: 2.0.0
> Environment: 2000+ Region Servers
> PCI-E ssd
> Reporter: Chance Li
> Assignee: Chance Li
> Priority: Critical
> Fix For: 3.0.0, 2.1.0
>
> Attachments: CSLM-concurrent-write.png,
> HBASE-19389-branch-2-V10.patch, HBASE-19389-branch-2-V2.patch,
> HBASE-19389-branch-2-V3.patch, HBASE-19389-branch-2-V4.patch,
> HBASE-19389-branch-2-V5.patch, HBASE-19389-branch-2-V6.patch,
> HBASE-19389-branch-2-V7.patch, HBASE-19389-branch-2-V8.patch,
> HBASE-19389-branch-2-V9.patch, HBASE-19389-branch-2.patch,
> HBASE-19389.master.patch, HBASE-19389.master.v2.patch, metrics-1.png,
> ycsb-result.png
>
>
> In a large cluster, with a large number of clients, we found the RS's
> handlers are all busy sometimes. And after investigation we found the root
> cause is about CSLM, such as compare function heavy load. We reviewed the
> related WALs, and found that there were many columns (more than 1000 columns)
> were writing at that time.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
