[
https://issues.apache.org/jira/browse/HBASE-20259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16421636#comment-16421636
]
Anastasia Braginsky commented on HBASE-20259:
---------------------------------------------
[~stack],
This Jira should be about fixing the effect of setting
{{hbase.systemtables.compacting.memstore.type}} to NONE. But not about turning
off the CompactingMemStore, which is done here under changing the default of
CompactingMemStore type to NONE. Definitely not based on a not-yet-accomplished
evaluation testing. This is not a small fix, and should not be done like that.
I am sorry, I do not agree. I would suggest that for now, please remove:
{code:java}
public static final String COMPACTING_MEMSTORE_TYPE_KEY =
"hbase.hregion.compacting.memstore.type";
public static final String COMPACTING_MEMSTORE_TYPE_DEFAULT =
- String.valueOf(MemoryCompactionPolicy.BASIC);
+ String.valueOf(MemoryCompactionPolicy.NONE);{code}
And because the patch is a bit long, please put it on the review board to make
the review process easier. Thank you very much!
> hbase.systemtables.compacting.memstore.type=NONE does not do as expected
> ------------------------------------------------------------------------
>
> Key: HBASE-20259
> URL: https://issues.apache.org/jira/browse/HBASE-20259
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: stack
> Priority: Critical
> Fix For: 2.0.0
>
> Attachments: HBASE-20259.master.001.patch,
> HBASE-20259.master.002.patch
>
>
> I set {{hbase.systemtables.compacting.memstore.type}} to NONE but it seems
> like in-memory is still on. My table looks like this:
> {code}
> Table ycsb is ENABLED
> ycsb
> COLUMN FAMILIES DESCRIPTION
> {NAME => 'family', VERSIONS => '1', EVICT_BLOCKS_ON_CLOSE => 'false',
> NEW_VERSION_BEHAVIOR => 'false', KEEP_DELETED_CELLS => 'FALSE',
> CACHE_DATA_ON_WRITE => 'false', DATA_BLOCK_ENCODING => 'NONE', TTL =>
> 'FOREVER', MIN_VERSIONS => '0', REPLICATION_SCOPE => '0', BLOOMFILTER =
> > 'ROW', CACHE_INDEX_ON_WRITE => 'false', IN_MEMORY => 'false',
> > CACHE_BLOOMS_ON_WRITE => 'false', PREFETCH_BLOCKS_ON_OPEN => 'false',
> > COMPRESSION => 'NONE', BLOCKCACHE => 'true', BLOCKSIZE => '65536'}
> {code}
> Looks like table doesn't have it on either (IN_MEMORY_COMPACTION doesn't show
> in the above).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
