[
https://issues.apache.org/jira/browse/HBASE-20312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16422237#comment-16422237
]
Hadoop QA commented on HBASE-20312:
-----------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
11s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 22 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
33s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
50s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
8s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
43s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 6m
29s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
21s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
46s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
14s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
38s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 1m
9s{color} | {color:red} hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 1m 9s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
20s{color} | {color:red} hbase-server: The patch generated 150 new + 453
unchanged - 1 fixed = 603 total (was 454) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
48s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
19m 20s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 3m
21s{color} | {color:red} hbase-server generated 16 new + 0 unchanged - 0 fixed
= 16 total (was 0) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m
30s{color} | {color:red} hbase-server generated 4 new + 2 unchanged - 0 fixed =
6 total (was 2) {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
18s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}148m 38s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
44s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}202m 3s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hbase-server |
| | Possible null pointer dereference of e in
org.apache.hadoop.hbase.ipc.RpcServer.call(RpcCall, MonitoredRPCHandler)
Dereferenced at RpcServer.java:e in
org.apache.hadoop.hbase.ipc.RpcServer.call(RpcCall, MonitoredRPCHandler)
Dereferenced at RpcServer.java:[line 468] |
| |
org.apache.hadoop.hbase.regionserver.skiplist.core.AllocatorHandlerRegister$AllocatorHandlerBuilder.INSTANCE
isn't final and can't be protected from malicious code At
AllocatorHandlerRegister.java:be protected from malicious code At
AllocatorHandlerRegister.java:[line 54] |
| | Possible doublecheck on
org.apache.hadoop.hbase.regionserver.skiplist.core.CCSMapChunkPool.globalInstance
in
org.apache.hadoop.hbase.regionserver.skiplist.core.CCSMapChunkPool.initialize(Configuration,
long, int, int, boolean) At
CCSMapChunkPool.java:org.apache.hadoop.hbase.regionserver.skiplist.core.CCSMapChunkPool.initialize(Configuration,
long, int, int, boolean) At CCSMapChunkPool.java:[lines 239-243] |
| | Private method
org.apache.hadoop.hbase.regionserver.skiplist.core.CompactedConcurrentSkipList.findPredecessor(INode,
int) is never called At CompactedConcurrentSkipList.java:never called At
CompactedConcurrentSkipList.java:[line 528] |
| |
org.apache.hadoop.hbase.regionserver.skiplist.hbase.CCSMapCellComparatorDirectly.compareTo(Cell,
ByteBuffer, int, int) negates the return value of
org.apache.hadoop.hbase.regionserver.skiplist.hbase.CCSMapCellComparatorDirectly.compareTo(ByteBuffer,
int, int, Cell) At CCSMapCellComparatorDirectly.java:the return value of
org.apache.hadoop.hbase.regionserver.skiplist.hbase.CCSMapCellComparatorDirectly.compareTo(ByteBuffer,
int, int, Cell) At CCSMapCellComparatorDirectly.java:[line 154] |
| |
org.apache.hadoop.hbase.regionserver.skiplist.hbase.CCSMapMemStore.CCSMAP_USE_OFFHEAP
isn't final but should be At CCSMapMemStore.java:be At
CCSMapMemStore.java:[line 49] |
| |
org.apache.hadoop.hbase.regionserver.skiplist.hbase.CCSMapMemStore.CHUNK_CAPACITY_KEY
isn't final but should be At CCSMapMemStore.java:be At
CCSMapMemStore.java:[line 43] |
| |
org.apache.hadoop.hbase.regionserver.skiplist.hbase.CCSMapMemStore.CHUNK_SIZE_DEFAULT
isn't final but should be At CCSMapMemStore.java:be At
CCSMapMemStore.java:[line 48] |
| |
org.apache.hadoop.hbase.regionserver.skiplist.hbase.CCSMapMemStore.CHUNK_SIZE_KEY
isn't final but should be At CCSMapMemStore.java:be At
CCSMapMemStore.java:[line 46] |
| |
org.apache.hadoop.hbase.regionserver.skiplist.hbase.CCSMapMemStore.EXTRA_CHUNK_WARN_CAPACITY
isn't final but should be At CCSMapMemStore.java:be At
CCSMapMemStore.java:[line 44] |
| |
org.apache.hadoop.hbase.regionserver.skiplist.hbase.CCSMapMemStore.INITIAL_CHUNK_COUNT_KEY
isn't final but should be At CCSMapMemStore.java:be At
CCSMapMemStore.java:[line 47] |
| |
org.apache.hadoop.hbase.regionserver.skiplist.hbase.CellCCSMap.CCSMAP_COMPARATOR_DEFAULT
isn't final but should be At CellCCSMap.java:be At CellCCSMap.java:[line 37]
|
| |
org.apache.hadoop.hbase.regionserver.skiplist.hbase.CellCCSMap.CCSMAP_COMPARATOR_KEY
isn't final but should be At CellCCSMap.java:be At CellCCSMap.java:[line 36]
|
| |
org.apache.hadoop.hbase.regionserver.skiplist.hbase.CellCCSMap.TEST_CCSMAP_USE_OFFHEAP
isn't final but should be At CellCCSMap.java:be At CellCCSMap.java:[line 41]
|
| |
org.apache.hadoop.hbase.regionserver.skiplist.hbase.CellCCSMap.TEST_CHUNK_CAPACITY_KEY
isn't final but should be At CellCCSMap.java:be At CellCCSMap.java:[line 39]
|
| |
org.apache.hadoop.hbase.regionserver.skiplist.hbase.CellCCSMap.TEST_CHUNK_SIZE_KEY
isn't final but should be At CellCCSMap.java:be At CellCCSMap.java:[line 40]
|
| Failed junit tests | hadoop.hbase.client.TestAdmin1 |
| | hadoop.hbase.replication.TestSerialReplication |
| | hadoop.hbase.regionserver.TestHRegionReplayEvents |
| | hadoop.hbase.client.TestFromClientSide3 |
| | hadoop.hbase.regionserver.TestRegionReplicasAreDistributed |
| |
hadoop.hbase.replication.multiwal.TestReplicationSyncUpToolWithMultipleWAL |
| | hadoop.hbase.regionserver.TestPerColumnFamilyFlush |
| | hadoop.hbase.util.TestRegionSplitter |
| | hadoop.hbase.regionserver.TestGetClosestAtOrBefore |
| | hadoop.hbase.regionserver.TestRegionReplicasWithModifyTable |
| | hadoop.hbase.master.cleaner.TestReplicationBarrierCleaner |
| | hadoop.hbase.client.TestAsyncTableAdminApi |
| | hadoop.hbase.client.TestMobRestoreSnapshotFromClient |
| | hadoop.hbase.client.TestAdmin2 |
| | hadoop.hbase.client.TestTableFavoredNodes |
| | hadoop.hbase.regionserver.TestRegionReplicasWithRestartScenarios |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:d8b550f |
| JIRA Issue | HBASE-20312 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12917175/HBASE-20312-master.v1.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 9691b5748f44 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9
14:43:09 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 1e56938757 |
| maven | version: Apache Maven 3.5.3
(3383c37e1f9e9b3bc3df5050c29c8aff9f295297; 2018-02-24T19:49:05Z) |
| Default Java | 1.8.0_162 |
| findbugs | v3.1.0-RC3 |
| compile |
https://builds.apache.org/job/PreCommit-HBASE-Build/12260/artifact/patchprocess/patch-compile-hbase-server.txt
|
| javac |
https://builds.apache.org/job/PreCommit-HBASE-Build/12260/artifact/patchprocess/patch-compile-hbase-server.txt
|
| checkstyle |
https://builds.apache.org/job/PreCommit-HBASE-Build/12260/artifact/patchprocess/diff-checkstyle-hbase-server.txt
|
| findbugs |
https://builds.apache.org/job/PreCommit-HBASE-Build/12260/artifact/patchprocess/new-findbugs-hbase-server.html
|
| javadoc |
https://builds.apache.org/job/PreCommit-HBASE-Build/12260/artifact/patchprocess/diff-javadoc-javadoc-hbase-server.txt
|
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/12260/artifact/patchprocess/patch-unit-hbase-server.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/12260/testReport/ |
| Max. process+thread count | 4681 (vs. ulimit of 10000) |
| modules | C: hbase-common hbase-server U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/12260/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> CCSMap: A faster, GC-friendly, less memory Concurrent Map for memstore
> ----------------------------------------------------------------------
>
> Key: HBASE-20312
> URL: https://issues.apache.org/jira/browse/HBASE-20312
> Project: HBase
> Issue Type: New Feature
> Components: regionserver
> Reporter: Xiang Wang
> Assignee: Chance Li
> Priority: Major
> Fix For: 3.0.0
>
> Attachments: HBASE-20312-1.3.2.patch, HBASE-20312-master.v1.patch,
> ccsmap-branch-1.1.patch, jira1.png, jira2.png, jira3.png
>
>
> Now hbase use ConcurrentSkipListMap as memstore's data structure.
> Although MemSLAB reduces memory fragment brought by key-value pairs.
> Hundred of millions key-value pairs still make young generation
> garbage-collection(gc) stop time long.
>
> These are 2 gc problems of ConcurrentSkipListMap:
> 1. HBase needs 3 objects to store one key-value on expectation. One
> Index(skiplist's average node height is 1), one Node, and one KeyValue. Too
> many objects are created for memstore.
> 2. Recent inserted KeyValue and its map structure(Index, Node) are assigned
> on young generation.The card table (for CMS gc algorithm) or RSet(for G1 gc
> algorithm) will change frequently on high writing throughput, which makes YGC
> slow.
>
> We devleoped a new skip-list map called CompactdConcurrentSkipListMap(CCSMap
> for short),
> which provides similary features like ConcurrentSkipListMap but get rid of
> Objects for every key-value pairs.
> CCSMap's memory structure is like this picture:
> !jira1.png!
>
> One CCSMap consists of a certain number of Chunks. One Chunk consists of a
> certain number of nodes. One node is corresspding one element. This element's
> all information and its key-value is encoded on a continuous memory segment
> without any objects.
> Features:
> 1. all insert,update,delete operations is lock-free on CCSMap.
> 2. Consume less memory, it brings 40% memory saving for 50Byte key-value.
> 3. Faster on small key-value because of better cacheline usage. 20~30% better
> read/write troughput than ConcurrentSkipListMap for 50Byte key-value.
> CCSMap do not support recyle space when deleting element. But it doesn't
> matter for hbase because of region flush.
> CCSMap has been running on Alibaba's hbase clusters over 17 months, it cuts
> down YGC time significantly. here are 2 graph of before and after.
> !jira2.png!
> !jira3.png!
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
