[
https://issues.apache.org/jira/browse/HBASE-5270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208803#comment-13208803
]
stack commented on HBASE-5270:
------------------------------
@Chunhui Excellent.
I am all good w/ modifying core to make it more testable. Would suggest
instead though that you make more generic changes up in Master, etc.
For example, the attached patch makes it so a subclass of HMaster can observe
log splitting and insert pauses and override the RegionServerTracker to pause
on deletes until a gate is cleared. This might make more sense than the custom
changes made to RegionServerTracker and HMaster in this patch.
On the patch, I think the HMaster and RegionServerTracker changes are too
specific to this test case. Would suggest making more generic changes to these
core classes because other tests will be able to make use of a more generic
change (I think its good to mod core classes to make them more testable).
'
On the test, can we have a better name than TestHRegionserverKilled? It
doesn't say what this test does (testDataCorrectnessWhenMasterFailOver might be
better as class name).
Why do this:
+ Configuration conf = HBaseConfiguration.create();
Why not use whats in your HBaseTestingUtility (do a getConfiguration -- see the
attached test).
Also, you might use the junit primitives for test setup and teardown as per the
attache test.
> Handle potential data loss due to concurrent processing of processFaileOver
> and ServerShutdownHandler
> -----------------------------------------------------------------------------------------------------
>
> Key: HBASE-5270
> URL: https://issues.apache.org/jira/browse/HBASE-5270
> Project: HBase
> Issue Type: Sub-task
> Components: master
> Reporter: Zhihong Yu
> Fix For: 0.94.0, 0.92.1
>
> Attachments: 5270-90-testcase.patch, 5270-90.patch,
> 5270-testcase.patch, hbase-5270.patch
>
>
> This JIRA continues the effort from HBASE-5179. Starting with Stack's
> comments about patches for 0.92 and TRUNK:
> Reviewing 0.92v17
> isDeadServerInProgress is a new public method in ServerManager but it does
> not seem to be used anywhere.
> Does isDeadRootServerInProgress need to be public? Ditto for meta version.
> This method param names are not right 'definitiveRootServer'; what is meant
> by definitive? Do they need this qualifier?
> Is there anything in place to stop us expiring a server twice if its carrying
> root and meta?
> What is difference between asking assignment manager isCarryingRoot and this
> variable that is passed in? Should be doc'd at least. Ditto for meta.
> I think I've asked for this a few times - onlineServers needs to be
> explained... either in javadoc or in comment. This is the param passed into
> joinCluster. How does it arise? I think I know but am unsure. God love the
> poor noob that comes awandering this code trying to make sense of it all.
> It looks like we get the list by trawling zk for regionserver znodes that
> have not checked in. Don't we do this operation earlier in master setup? Are
> we doing it again here?
> Though distributed split log is configured, we will do in master single
> process splitting under some conditions with this patch. Its not explained in
> code why we would do this. Why do we think master log splitting 'high
> priority' when it could very well be slower. Should we only go this route if
> distributed splitting is not going on. Do we know if concurrent distributed
> log splitting and master splitting works?
> Why would we have dead servers in progress here in master startup? Because a
> servershutdownhandler fired?
> This patch is different to the patch for 0.90. Should go into trunk first
> with tests, then 0.92. Should it be in this issue? This issue is really hard
> to follow now. Maybe this issue is for 0.90.x and new issue for more work on
> this trunk patch?
> This patch needs to have the v18 differences applied.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
