[
https://issues.apache.org/jira/browse/HBASE-20276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16426158#comment-16426158
]
Sean Busbey commented on HBASE-20276:
-------------------------------------
because one of the things HBASE-15965 changed was to print out more details for
the get_splits command, but to do it in the building block function
{{HBase::Table::_get_splits_internal}}. That method currently also gets used by
several tests that don't care about output, and it's also useful if someone
needs to reach behind our supported interface to build something programmatic
that will operate directly on the splits (ala the stuff in HBASE-15611).
printing the splits in the internal part instead of in the user facing part
where it presumably is usefully consumed seemed off, so I moved that part to
the user facing command. The summary blurb about number of splits seemed
similarly out of place though it's been there much longer, so I moved it over
as well.
The net result is that those properly using {{get_splits}} directly get the
same output as before, but when we're hitting internal for it we skip having
{{puts}} without reimplementing the function.
> [shell] Revert shell REPL change and document
> ---------------------------------------------
>
> Key: HBASE-20276
> URL: https://issues.apache.org/jira/browse/HBASE-20276
> Project: HBase
> Issue Type: Sub-task
> Components: documentation, shell
> Affects Versions: 1.4.0, 2.0.0
> Reporter: Sean Busbey
> Assignee: Sean Busbey
> Priority: Blocker
> Fix For: 1.4.4, 2.0.0
>
> Attachments: HBASE-20276.0.patch
>
>
> Feedback from [~mdrob] on HBASE-19158:
> {quote}
> Shell:
> HBASE-19770. There was another issue opened where this was identified as a
> problem so maybe the shape will change further, but I can't find it now.
> {quote}
> New commentary from [~busbey]:
> This was a follow on to HBASE-15965. That change effectively makes it so none
> of our ruby wrappers can be used to build expressions in an interactive REPL.
> This is a pretty severe change (most of my tips on HBASE-15611 will break, I
> think).
> I think we should
> a) Have a DISCUSS thread, spanning dev@ and user@
> b) based on the outcome of that thread, either default to the new behavior or
> the old behavior
> c) if we keep the HBASE-15965 behavior as the default, flag it as
> incompatible, call it out in the hbase 2.0 upgrade section, and update docs
> (two examples: the output in the shell_exercises sections would be wrong, and
> the _table_variables section won't work)
> d) In either case document the new flag in the ref guide
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
