[
https://issues.apache.org/jira/browse/HBASE-15466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sean Busbey updated HBASE-15466:
--------------------------------
Status: Patch Available (was: In Progress)
-v0
* add a new test to build the refguide specifically instead of site
* check for changes to src/main/asciidoc and run that test and only that
test
* fallback to relying on the yetus default for other changes
* fix some missing start_clock entries that cause longer-than-actual
reported test time.
Running this locally looks to do the correct thing.
ex docs-only patch on HBASE-20355
{code}
$ test-patch --project=hbase --personality=dev-support/hbase-personality.sh
--run-tests --quick-hadoopcheck HBASE-20355 2>&1 | tee
~/Downloads/yetus.HBASE-20355.log
...
+1 overall
____ _
/ ___| _ _ ___ ___ ___ ___ ___| |
\___ \| | | |/ __/ __/ _ \/ __/ __| |
___) | |_| | (_| (_| __/\__ \__ \_|
|____/ \__,_|\___\___\___||___/___(_)
| Vote | Subsystem | Runtime | Comment
============================================================================
| | | | Prechecks
| +1 | @author | 0m 00s | The patch does not contain any @author
| | | | tags.
| | | | HBASE-15466 Compile Tests
| +1 | mvninstall | 6m 21s | HBASE-15466 passed
| +1 | refguide | 2m 52s | The patch has no errors when building
| | | | the reference guide.
| | | | Patch Compile Tests
| +1 | whitespace | 0m 00s | The patch has no whitespace issues.
| +1 | refguide | 2m 45s | The patch has no errors when building
| | | | the reference guide.
| | | | Other Tests
| +1 | asflicense | 0m 21s | The patch does not generate ASF License
| | | | warnings.
| | | 12m 42s |
|| Subsystem || Report/Notes ||
============================================================================
| JIRA Issue | HBASE-20355 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12917750/HBASE-20355.1.patch |
| Optional Tests | asflicense refguide |
| uname | Darwin Busbey-MBA 15.6.0 Darwin Kernel Version 15.6.0: Tue Jan 9
20:12:05 PST 2018; root:xnu-3248.73.5~1/RELEASE_X86_64 x86_64 |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | HBASE-15466 / f3ca9363ab |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T02:58:13-05:00) |
| modules | C: . U: . |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
============================================================================
============================================================================
Finished build.
============================================================================
============================================================================
{code}
example non docs patch on HBASE-20338 (chosen since it doesn't cause
hbase-server unit tests)
{code}
$ test-patch --project=hbase --personality=dev-support/hbase-personality.sh
--run-tests —-quick-hadoopcheck HBASE-20338 2>&1 | tee
~/Downloads/yetus.HBASE-20338.log
...
-1 overall
_____ _ _ _
| ___|_ _(_) |_ _ _ __ ___| |
| |_ / _` | | | | | | '__/ _ \ |
| _| (_| | | | |_| | | | __/_|
|_| \__,_|_|_|\__,_|_| \___(_)
| Vote | Subsystem | Runtime | Comment
============================================================================
| | | | Prechecks
| 0 | findbugs | 0m 00s | Findbugs executables are not available.
| +1 | hbaseanti | 0m 00s | Patch does not have any anti-patterns.
| +1 | @author | 0m 00s | The patch does not contain any @author
| | | | tags.
| -1 | test4tests | 0m 00s | The patch doesn't appear to include any
| | | | new or modified tests. Please justify
| | | | why no new tests are needed for this
| | | | patch. Also please list what manual
| | | | steps were performed to verify this
| | | | patch.
| | | | HBASE-15466 Compile Tests
| +1 | mvninstall | 6m 54s | HBASE-15466 passed
| +1 | compile | 0m 33s | HBASE-15466 passed
| +1 | checkstyle | 0m 25s | HBASE-15466 passed
| +1 | shadedjars | 6m 13s | branch has no errors when building our
| | | | shaded downstream artifacts.
| +1 | javadoc | 0m 25s | HBASE-15466 passed
| | | | Patch Compile Tests
| +1 | mvninstall | 9m 12s | the patch passed
| +1 | compile | 0m 35s | the patch passed
| -1 | javac | 0m 35s | hbase-procedure generated 9 new + 0
| | | | unchanged - 9 fixed = 9 total (was 9)
| +1 | checkstyle | 0m 21s | the patch passed
| +1 | whitespace | 0m 00s | The patch has no whitespace issues.
| +1 | shadedjars | 6m 12s | patch has no errors when building our
| | | | shaded downstream artifacts.
| +1 | hadoopcheck | 26m 08s | Patch does not cause any errors with
| | | | Hadoop 2.6.5 2.7.4 or 3.0.0.
| +1 | javadoc | 1m 09s | the patch passed
| | | | Other Tests
| +1 | unit | 9m 18s | hbase-procedure in the patch passed.
| +1 | asflicense | 0m 49s | The patch does not generate ASF License
| | | | warnings.
| | | 68m 33s |
|| Subsystem || Report/Notes ||
============================================================================
| JIRA Issue | HBASE-20338 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12917848/HBASE-20338.master.002.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Darwin Busbey-MBA 15.6.0 Darwin Kernel Version 15.6.0: Tue Jan 9
20:12:05 PST 2018; root:xnu-3248.73.5~1/RELEASE_X86_64 x86_64 |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | HBASE-15466 / f3ca9363ab |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T02:58:13-05:00) |
| Default Java | 1.8.0_74 |
| javac | /private/tmp/yetus-10141.22234/diff-compile-javac-hbase-procedure.txt
|
| modules | C: hbase-procedure U: hbase-procedure |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
============================================================================
============================================================================
Finished build.
============================================================================
============================================================================
{code}
in the docs-only case, that's a savings of 2-4 hours depending on how stable
the tests are.
> precommit should not run all java goals when given a docs-only patch
> --------------------------------------------------------------------
>
> Key: HBASE-15466
> URL: https://issues.apache.org/jira/browse/HBASE-15466
> Project: HBase
> Issue Type: Improvement
> Components: build
> Reporter: Sean Busbey
> Assignee: Sean Busbey
> Priority: Major
> Attachments: HBASE-15466.0.patch
>
>
> Right now docs-only patches (those that only impact the top level
> src/main/site, src/main/asciidoc, or src/main/xslt) run through all of the
> java related precommit checks, including test4tests and the full unit test
> suite.
> Since we know these paths don't require those checks, we should update our
> personality to skip them. (or fix our project structure to match "the maven
> way".)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
