[ 
https://issues.apache.org/jira/browse/HBASE-19761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16429727#comment-16429727
 ] 

maoling commented on HBASE-19761:
---------------------------------

[~Jan Hentschel]  sorry for the old v0 patch.

It may be hard to fix Checkstyle errors in hbase-zookeeper beacuse 
{code:java}
org.apache.hadoop.hbase.zookeeper.ZKWatcher.
public final ZNodePaths znodePaths; // znodePaths is public
{code}
But when run maven checkstyle,it hints this:
{code:java}
[ERROR] src\main\java\org\apache\hadoop\hbase\zookeeper\ZKWatcher.java:[79,27] 
(design) VisibilityModifier:  'znodePaths' should be private
{code}
It is trouble *znodePaths* are called by many codes in other modules which 
can't be  *private*


> Fix Checkstyle errors in hbase-zookeeper
> ----------------------------------------
>
>                 Key: HBASE-19761
>                 URL: https://issues.apache.org/jira/browse/HBASE-19761
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Jan Hentschel
>            Assignee: maoling
>            Priority: Minor
>         Attachments: HBASE-19761-master-v0.patch
>
>
> Fix the remaining Checkstyle errors in the *hbase-zookeeper* module and 
> enable Checkstyle to fail on violations.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to