[
https://issues.apache.org/jira/browse/HBASE-4403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13209679#comment-13209679
]
stack commented on HBASE-4403:
------------------------------
What kind of feedback do you need Jimmy?
These are deprecated:
org/apache/hadoop/hbase/HServerAddress.java
org/apache/hadoop/hbase/HServerInfo.java
I suppose you want to mark them anyways.
Its ugly that the below is Audience=public and Stability-Evolving but I suppose
it the truth:
org/apache/hadoop/hbase/KeyValue.java
I see this is still evolving:
org/apache/hadoop/hbase/ClusterStatus.java
(Its having backup masters added as we speak)
Is this public?
org/apache/hadoop/hbase/ClockOutOfSyncException.java
I mean client can get it?
Maybe this should be too...
org/apache/hadoop/hbase/LocalHBaseCluster.java
Its a useful tool I'd think.
Some of these public=private are used in tests... does that make it
audience=public? Or test building blocks are for devs and so audience=public
Do we have defines for these classifications? If so, should go into dev
section of manual... or into index or something.
Is org/apache/hadoop/hbase/client/HConnectionManager.java public? Should be
private? Would be good if connection implementation was 'hidden'
org/apache/hadoop/hbase/io/TimeRange.java is in io? Doesn't that come through
in client api? I'd think it stable too. Seems like its in wrong package.
Master and Regionserver has stuff that is used in tests too...
Some stuff in Util could be public... the Keying utility class, the Strings
class...
Otherwise +1. Good stuff.
> Adopt interface stability/audience classifications from Hadoop
> --------------------------------------------------------------
>
> Key: HBASE-4403
> URL: https://issues.apache.org/jira/browse/HBASE-4403
> Project: HBase
> Issue Type: Task
> Affects Versions: 0.90.5, 0.92.0
> Reporter: Todd Lipcon
> Assignee: Jimmy Xiang
> Attachments: hbase-4403-interface.txt,
> hbase-4403-nowhere-near-done.txt
>
>
> As HBase gets more widely used, we need to be more explicit about which APIs
> are stable and not expected to break between versions, which APIs are still
> evolving, etc. We also have many public classes that are really internal to
> the RS or Master and not meant to be used by users. Hadoop has adopted a
> classification scheme for audience (public, private, or limited-private) as
> well as stability (stable, evolving, unstable). I think we should copy these
> annotations to HBase and start to classify our public classes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
