stack commented on HBASE-20358:

+1 for branch-2.0.

This looks like a change in how we start/stop thrift? It is a long-needed 
improvement for sure but a change nonetheless.  Please call it out as 
'breaking' change and make a release note please lads. Thanks.

> Fix bin/hbase thrift usage text
> -------------------------------
>                 Key: HBASE-20358
>                 URL: https://issues.apache.org/jira/browse/HBASE-20358
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 2.0.0-beta-2
>            Reporter: Balazs Meszaros
>            Assignee: Balazs Meszaros
>            Priority: Minor
>             Fix For: 2.0.0
>         Attachments: HBASE-20358.branch-2.0.001.patch
> 1. Thrift server usage text does not say anything about it requires a 
> {{start}} or {{stop}} argument.
>  2. It ignores {{stop}} argument, it acts as the same as for {{start}}.
> According to this comment:
> {code:java}
> // This is so complicated to please both bin/hbase and bin/hbase-daemon.
> // hbase-daemon provides "start" and "stop" arguments
> // hbase should print the help if no argument is provided
> {code}
> {{start}} and {{stop}} is just supported because {{bin/hbase-daemon}}, but 
> hbase-daemon kills the process instead of calling it with a {{stop}} argument.

This message was sent by Atlassian JIRA

Reply via email to