[
https://issues.apache.org/jira/browse/HBASE-20395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16436688#comment-16436688
]
Guangxu Cheng commented on HBASE-20395:
---------------------------------------
{quote}ThriftMetrics instance can be retrieved from the respective thrift
server class.
Can we get the type information from that instance instead of introducing
another config ?
{quote}
Sorry, I missed this message.
{code:java}
InfoServer infoServer = new InfoServer("thrift", a, port, false, conf);
infoServer.setAttribute("hbase.conf", conf);
// set new Attribute
infoServer.setAttribute("hbase.thrift.metric", metrics);
//or
infoServer.setAttribute("hbase.thrift", this);
{code}
Hi,[[email protected]]. Do you mean to set ThriftMetrics or ThriftServer
instance as an attribute of InfoServer? However, this also requires adding a
new config "hbase.thrift.metric" or "hbase.thrift".
I introduce a new config, which is considered to be consistent with other
configs(implType,framed etc.), and this may be simpler.
> Displaying thrift server type on the thrift page
> ------------------------------------------------
>
> Key: HBASE-20395
> URL: https://issues.apache.org/jira/browse/HBASE-20395
> Project: HBase
> Issue Type: Improvement
> Components: Thrift
> Reporter: Guangxu Cheng
> Assignee: Guangxu Cheng
> Priority: Major
> Attachments: HBASE-20395.master.001.patch,
> HBASE-20395.master.002.patch, result.png
>
>
> HBase supports two types of thrift server: thrift and thrift2.
> But after start the thrift server successfully, we can not get the thrift
> server type conveniently.
> So, displaying thrift server type on the thrift page may provide some
> convenience for the users.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
