[
https://issues.apache.org/jira/browse/HBASE-5418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13209906#comment-13209906
]
Phabricator commented on HBASE-5418:
------------------------------------
tedyu has commented on the revision "HBASE-5418 [jira] use different memstoreTS
for different operations in the same RowMutation.".
INLINE COMMENTS
src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java:4245 Should
ctr be lifted to above the try block so that we only call
mvcc.completeMemstoreInsert() for the WriteEntry's we actually touched ?
src/main/java/org/apache/hadoop/hbase/regionserver/MultiVersionConsistencyControl.java:121
Should we simplify beginMemstoreInsert() by letting it call this new method ?
This would allow maintaining one method instead of two in case we add
something in the future.
REVISION DETAIL
https://reviews.facebook.net/D1761
> use different memstoreTS for different operations in the same RowMutation.
> --------------------------------------------------------------------------
>
> Key: HBASE-5418
> URL: https://issues.apache.org/jira/browse/HBASE-5418
> Project: HBase
> Issue Type: Sub-task
> Components: client, coprocessors, regionserver
> Reporter: Amitanand Aiyer
> Assignee: Amitanand Aiyer
> Fix For: 0.94.0
>
> Attachments: HBASE-5418.D1761.1.patch
>
>
> Assigning different memstoreTS will enable us to guarantee that the
> operations will appear to take effect, along the same order, in which
> they were added to create the RowMutation.
> Based on the diff after renaming to RowMutations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
