[ 
https://issues.apache.org/jira/browse/HBASE-20233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16438179#comment-16438179
 ] 

Xu Cang edited comment on HBASE-20233 at 4/14/18 1:34 AM:
----------------------------------------------------------

No new unit tests added because this change is minimal, just removed one 
redundant metric.

The manual test has been done. I verified the numsRegions metric is removed 
from JMX.


was (Author: xucang):
No new unit tests added because this change is minimal, just removed one 
redundant metric.

The manual test has been done. I verified the numsRegion metrics is removed 
from JMX.

> [metrics] Ill-formatted numRegions metric in 
> "Hadoop:service=HBase,name=RegionServer,sub=Regions" mbean
> -------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-20233
>                 URL: https://issues.apache.org/jira/browse/HBASE-20233
>             Project: HBase
>          Issue Type: Bug
>          Components: metrics
>            Reporter: stack
>            Assignee: Xu Cang
>            Priority: Trivial
>              Labels: beginner
>         Attachments: HBASE-20233-v1.patch, HBASE-20233.patch
>
>
> Noticed this poking at metrics. The MBean 
> "Hadoop:service=HBase,name=RegionServer,sub=Regions" carries per region 
> metrics. They are all formatted like so:
> {code}
> Namespace_default_table_IntegrationTestBigLinkedList_metric_incrementTime_98th_percentile:
>  0,
> Namespace_default_table_IntegrationTestBigLinkedList_metric_incrementTime_99th_percentile:
>  0,
> Namespace_default_table_IntegrationTestBigLinkedList_metric_incrementTime_99.9th_percentile:
>  0,
> Namespace_default_table_IntegrationTestBigLinkedList_metric_appendTime_num_ops:
>  0,
> Namespace_default_table_IntegrationTestBigLinkedList_metric_appendTime_min: 0,
> Namespace_default_table_IntegrationTestBigLinkedList_metric_appendTime_max: 0,
> Namespace_default_table_IntegrationTestBigLinkedList_metric_appendTime_mean: 
> 0,
> {code}
> In the middle of them all is a metric named...
> {code}
> numRegions: 15,
> {code}
> It has a different format and it is out of scope when compared to the other 
> metrics in this mbean; it belongs better elsewhere, perhaps in the Server 
> bean.
> I noticed it because it breaks the parse done by tcollector scraping our 
> metrics from /jmx
> It was added long ago in HBASE-14166



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to