[ 
https://issues.apache.org/jira/browse/HBASE-20420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16438919#comment-16438919
 ] 

lujie commented on HBASE-20420:
-------------------------------

[~Apache9]:

_AccessControlLists#removeTablePermissions_  call the _Result#getFamilyMap_ to 
get the _NavigableMap_, _getFamilyMap_  will return null while the Result 
isEmpty(eg Result.cell == null), i have analysed the code related the cell, I 
think it is possible to return null. But due to i am not very familiar to  
HBASE, so i may be wrong, and if so, i will update the patch.

And could you please review the other NPE case in the patch. 

Thanks very much.

> Fix Some Potential NPE 
> -----------------------
>
>                 Key: HBASE-20420
>                 URL: https://issues.apache.org/jira/browse/HBASE-20420
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 2.0.0-beta-2
>            Reporter: lujie
>            Priority: Major
>         Attachments: HBASE-20420_2.patch, hbase-20420.patch
>
>
> We have used the  tool [NPEDetector|https://github.com/lujiefsi/NPEDetector] 
> find another  six problems that similar to  HBASE-20419.
> list here and attach the patch.
>  CommonFSUtils#listStatus
> RSGroupInfoManagerImpl#getRSGroupOfServer
> BackupSystemTable#readBackupInfo
> SnapshotManifest#getRegionManifestsMap
> HRegionFileSystem#getFamilies
> Result#getFamilyMap



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to