Sean Busbey created HBASE-20438:
-----------------------------------
Summary: Add an HBase antipattern check for reintroducing
commons-logging
Key: HBASE-20438
URL: https://issues.apache.org/jira/browse/HBASE-20438
Project: HBase
Issue Type: Improvement
Components: dependencies, test
Affects Versions: 3.0.0, 2.1.0, 2.0.0
Reporter: Sean Busbey
Fix For: 3.0.0, 2.1.0, 2.0.1
We moved to slf4j in HBASE-10092, but looking at our source tree we've had some
regression back to commons-logging:
{code}
$ git grep -E "org.apache.commons.logging.Log(Factory|;)"
hbase-server/src/main/java/org/apache/hadoop/hbase/master/zksyncer/ClientZKSyncer.java:import
org.apache.commons.logging.Log;
hbase-server/src/main/java/org/apache/hadoop/hbase/master/zksyncer/ClientZKSyncer.java:import
org.apache.commons.logging.LogFactory;
hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/FileArchiverNotifierImpl.java:import
org.apache.commons.logging.Log;
hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/FileArchiverNotifierImpl.java:import
org.apache.commons.logging.LogFactory;
hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/RegionSizeReportingChore.java:import
org.apache.commons.logging.Log;
hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/RegionSizeReportingChore.java:import
org.apache.commons.logging.LogFactory;
hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/RegionSizeStoreImpl.java:import
org.apache.commons.logging.Log;
hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/RegionSizeStoreImpl.java:import
org.apache.commons.logging.LogFactory;
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/throttle/StoreHotnessProtector.java:import
org.apache.commons.logging.Log;
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/throttle/StoreHotnessProtector.java:import
org.apache.commons.logging.LogFactory;
hbase-server/src/test/java/org/apache/hadoop/hbase/TestClusterPortAssignment.java:import
org.apache.commons.logging.Log;
hbase-server/src/test/java/org/apache/hadoop/hbase/TestClusterPortAssignment.java:import
org.apache.commons.logging.LogFactory;
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFlushFromClient.java:import
org.apache.commons.logging.Log;
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFlushFromClient.java:import
org.apache.commons.logging.LogFactory;
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestSeparateClientZKCluster.java:import
org.apache.commons.logging.Log;
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestSeparateClientZKCluster.java:import
org.apache.commons.logging.LogFactory;
hbase-server/src/test/java/org/apache/hadoop/hbase/procedure/TestFailedProcCleanup.java:import
org.apache.commons.logging.Log;
hbase-server/src/test/java/org/apache/hadoop/hbase/procedure/TestFailedProcCleanup.java:import
org.apache.commons.logging.LogFactory;
hbase-server/src/test/java/org/apache/hadoop/hbase/wal/TestDisabledWAL.java:import
org.apache.commons.logging.Log;
hbase-server/src/test/java/org/apache/hadoop/hbase/wal/TestDisabledWAL.java:import
org.apache.commons.logging.LogFactory;
{code}
We should do the same kind of check that we do to avoid e.g. the Hadoop
annotations
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
