[
https://issues.apache.org/jira/browse/HBASE-20441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16443962#comment-16443962
]
Hadoop QA commented on HBASE-20441:
-----------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 4s{color}
| {color:red} HBASE-20441 does not apply to master. Rebase required? Wrong
Branch? See https://yetus.apache.org/documentation/0.7.0/precommit-patchnames
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HBASE-20441 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12919798/HBASE-20441.master.001.patch
|
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/12557/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> Add an HBase antipattern check for reintroducing commons-lang 2
> ---------------------------------------------------------------
>
> Key: HBASE-20441
> URL: https://issues.apache.org/jira/browse/HBASE-20441
> Project: HBase
> Issue Type: Task
> Components: dependencies, test
> Affects Versions: 2.0.0
> Reporter: Sean Busbey
> Assignee: Balazs Meszaros
> Priority: Major
> Fix For: 2.0.1
>
> Attachments: HBASE-20441.master.001.patch
>
>
> We updated to commons-lang 3 in HBASE-18674 but we've regressed:
> {code}
> $ git grep org.apache.commons.lang\\.
> hbase-common/src/main/java/org/apache/hadoop/hbase/net/Address.java:import
> org.apache.commons.lang.StringUtils;
> hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/FileArchiverNotifierFactoryImpl.java:import
> org.apache.commons.lang.builder.HashCodeBuilder;
> hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/FileArchiverNotifierImpl.java:import
> org.apache.commons.lang.builder.HashCodeBuilder;
> hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHdfsSnapshotHRegion.java:import
> org.apache.commons.lang.StringUtils;
> hbase-server/src/test/java/org/apache/hadoop/hbase/util/compaction/TestMajorCompactionRequest.java:import
> org.apache.commons.lang.RandomStringUtils;
> {code}
> we should add the same kind of check as we do for e.g. hadoop annotations.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
