[
https://issues.apache.org/jira/browse/HBASE-20447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16444753#comment-16444753
]
Zach York commented on HBASE-20447:
-----------------------------------
[~apurtell] Yep, Ted brought up a similar thing with the log level. I'll adjust
that to debug. Thanks for the review!
[[email protected]] This has been a RuntimeException for quite some time.
Any hard reasoning on why this should change to an IOE?
Otherwise your comments look good, I'll try to incorporate them.
[~anoop.hbase] I'm running into some issues getting the test to pass in master
(I think) due to the shared memory cache. What is happening is that even after
adding a block to the cache, the getBlock is returning the incorrect block. I
believe this might be related to it not being put in the backingMap yet, but
I'm not sure. Do you have any insight on that? Thanks!
> Only fail cacheBlock if block collisions aren't related to next block metadata
> ------------------------------------------------------------------------------
>
> Key: HBASE-20447
> URL: https://issues.apache.org/jira/browse/HBASE-20447
> Project: HBase
> Issue Type: Bug
> Components: BlockCache, BucketCache
> Affects Versions: 1.4.3, 2.0.0
> Reporter: Zach York
> Assignee: Zach York
> Priority: Major
> Fix For: 3.0.0, 2.1.0, 1.5.0, 1.4.4, 2.0.1
>
> Attachments: HBASE-20447.branch-1.001.patch,
> HBASE-20447.master.001.patch
>
>
> This is the issue I was originally having here:
> [http://mail-archives.apache.org/mod_mbox/hbase-dev/201802.mbox/%3CCAN+qs_Pav=md_aoj4xji+kcnetubg2xou2ntxv1g6m8-5vn...@mail.gmail.com%3E]
>
> When we pread, we don't force the read to read all of the next block header.
> However, when we get into a race condition where two opener threads try to
> cache the same block and one thread read all of the next block header and the
> other one didn't, it will fail the open process. This is especially important
> in a splitting case where it will potentially fail the split process.
> Instead, in the caches, we should only fail if the required blocks are
> different.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
