[
https://issues.apache.org/jira/browse/HBASE-5423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13210466#comment-13210466
]
stack commented on HBASE-5423:
------------------------------
Patch looks good Chunhui.
Change name of Set from addedRegionsToCallClose to closed.
Why do we have this Set? Are we calling close multiple times on same region?
So, we'd break even though online regions is not yet empty?
{code}
+ if (this.regionsInTransitionInRS.isEmpty()) {
+ break;
+ }
{code}
Thanks.
> Regionserver may block forever on waitOnAllRegionsToClose when aborting
> -----------------------------------------------------------------------
>
> Key: HBASE-5423
> URL: https://issues.apache.org/jira/browse/HBASE-5423
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: chunhui shen
> Assignee: chunhui shen
> Attachments: hbase-5423.patch
>
>
> If closeRegion throws any exception (It would be caused by FS ) when RS is
> aborting,
> RS will block forever on waitOnAllRegionsToClose().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
