[
https://issues.apache.org/jira/browse/HBASE-20438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16446465#comment-16446465
]
Hudson commented on HBASE-20438:
--------------------------------
Results for branch branch-2
[build #638 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/638/]:
(x) *{color:red}-1 overall{color}*
----
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/638//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/638//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/638//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Add an HBase antipattern check for reintroducing commons-logging
> ----------------------------------------------------------------
>
> Key: HBASE-20438
> URL: https://issues.apache.org/jira/browse/HBASE-20438
> Project: HBase
> Issue Type: Improvement
> Components: dependencies, test
> Affects Versions: 3.0.0, 2.1.0, 2.0.0
> Reporter: Sean Busbey
> Assignee: Nihal Jain
> Priority: Critical
> Fix For: 3.0.0, 2.1.0, 2.0.1
>
> Attachments: HBASE-20438.master.001.patch
>
>
> We moved to slf4j in HBASE-10092, but looking at our source tree we've had
> some regression back to commons-logging:
> {code}
> $ git grep -E "org.apache.commons.logging.Log(Factory|;)"
> hbase-server/src/main/java/org/apache/hadoop/hbase/master/zksyncer/ClientZKSyncer.java:import
> org.apache.commons.logging.Log;
> hbase-server/src/main/java/org/apache/hadoop/hbase/master/zksyncer/ClientZKSyncer.java:import
> org.apache.commons.logging.LogFactory;
> hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/FileArchiverNotifierImpl.java:import
> org.apache.commons.logging.Log;
> hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/FileArchiverNotifierImpl.java:import
> org.apache.commons.logging.LogFactory;
> hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/RegionSizeReportingChore.java:import
> org.apache.commons.logging.Log;
> hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/RegionSizeReportingChore.java:import
> org.apache.commons.logging.LogFactory;
> hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/RegionSizeStoreImpl.java:import
> org.apache.commons.logging.Log;
> hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/RegionSizeStoreImpl.java:import
> org.apache.commons.logging.LogFactory;
> hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/throttle/StoreHotnessProtector.java:import
> org.apache.commons.logging.Log;
> hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/throttle/StoreHotnessProtector.java:import
> org.apache.commons.logging.LogFactory;
> hbase-server/src/test/java/org/apache/hadoop/hbase/TestClusterPortAssignment.java:import
> org.apache.commons.logging.Log;
> hbase-server/src/test/java/org/apache/hadoop/hbase/TestClusterPortAssignment.java:import
> org.apache.commons.logging.LogFactory;
> hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFlushFromClient.java:import
> org.apache.commons.logging.Log;
> hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFlushFromClient.java:import
> org.apache.commons.logging.LogFactory;
> hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestSeparateClientZKCluster.java:import
> org.apache.commons.logging.Log;
> hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestSeparateClientZKCluster.java:import
> org.apache.commons.logging.LogFactory;
> hbase-server/src/test/java/org/apache/hadoop/hbase/procedure/TestFailedProcCleanup.java:import
> org.apache.commons.logging.Log;
> hbase-server/src/test/java/org/apache/hadoop/hbase/procedure/TestFailedProcCleanup.java:import
> org.apache.commons.logging.LogFactory;
> hbase-server/src/test/java/org/apache/hadoop/hbase/wal/TestDisabledWAL.java:import
> org.apache.commons.logging.Log;
> hbase-server/src/test/java/org/apache/hadoop/hbase/wal/TestDisabledWAL.java:import
> org.apache.commons.logging.LogFactory;
> {code}
> We should do the same kind of check that we do to avoid e.g. the Hadoop
> annotations
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
