[
https://issues.apache.org/jira/browse/HBASE-20467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16446475#comment-16446475
]
Hadoop QA commented on HBASE-20467:
-----------------------------------
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
16s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue} 0m
5s{color} | {color:blue} Shelldocs was not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m
2s{color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
13s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 0m 44s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:d8b550f |
| JIRA Issue | HBASE-20467 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12920106/HBASE-20467.master.001.patch
|
| Optional Tests | asflicense shellcheck shelldocs |
| uname | Linux 8c14439f827c 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9
14:43:09 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 273d252838 |
| maven | version: Apache Maven 3.5.3
(3383c37e1f9e9b3bc3df5050c29c8aff9f295297; 2018-02-24T19:49:05Z) |
| shellcheck | v0.4.4 |
| Max. process+thread count | 43 (vs. ulimit of 10000) |
| modules | C: . U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/12581/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> Precommit personality should only run checkstyle once if we're going to run
> it at the root.
> -------------------------------------------------------------------------------------------
>
> Key: HBASE-20467
> URL: https://issues.apache.org/jira/browse/HBASE-20467
> Project: HBase
> Issue Type: Bug
> Components: community, test
> Reporter: Sean Busbey
> Assignee: Nihal Jain
> Priority: Minor
> Labels: beginner
> Fix For: 3.0.0
>
> Attachments: HBASE-20467.master.001.patch
>
>
> shows up v egregiously on HBASE-20332, but I've seen in a few places where
> we'll do checkstyle at top level as well on individual modules.
> eg.:
> {code}
> +1 checkstyle 0m 25s hbase-common: The patch generated 0 new + 88
> unchanged - 1 fixed = 88 total (was 89)
> +1 checkstyle 0m 12s The patch hbase-hadoop2-compat passed checkstyle
> +1 checkstyle 0m 30s The patch hbase-client passed checkstyle
> +1 checkstyle 0m 11s The patch hbase-replication passed checkstyle
> +1 checkstyle 1m 15s The patch hbase-server passed checkstyle
> +1 checkstyle 0m 17s The patch hbase-mapreduce passed checkstyle
> +1 checkstyle 0m 8s The patch hbase-testing-util passed checkstyle
> +1 checkstyle 0m 28s The patch hbase-thrift passed checkstyle
> +1 checkstyle 0m 11s The patch hbase-rsgroup passed checkstyle
> +1 checkstyle 0m 10s The patch hbase-shell passed checkstyle
> +1 checkstyle 0m 12s The patch hbase-endpoint passed checkstyle
> +1 checkstyle 0m 14s The patch hbase-backup passed checkstyle
> +1 checkstyle 0m 21s The patch hbase-it passed checkstyle
> +1 checkstyle 0m 14s The patch hbase-examples passed checkstyle
> +1 checkstyle 0m 16s The patch hbase-rest passed checkstyle
> +1 checkstyle 0m 9s The patch hbase-external-blockcache passed
> checkstyle
> +1 checkstyle 0m 10s The patch hbase-shaded passed checkstyle
> +1 checkstyle 0m 8s The patch hbase-shaded-mapreduce passed
> checkstyle
> +1 checkstyle 0m 8s The patch hbase-shaded-check-invariants passed
> checkstyle
> +1 checkstyle 0m 9s The patch
> hbase-shaded-with-hadoop-check-invariants passed checkstyle
> +1 checkstyle 2m 38s root: The patch generated 0 new + 429 unchanged
> - 1 fixed = 429 total (was 430)
> {code}
> we should use the same shortcut we do with other modules when root is present
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
