[ 
https://issues.apache.org/jira/browse/HBASE-19746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16447142#comment-16447142
 ] 

Chia-Ping Tsai edited comment on HBASE-19746 at 4/22/18 8:25 AM:
-----------------------------------------------------------------

{quote}In that case we'd need to deprecate `Cell#getType()` in 2.0 but that has 
not happened. It's not marked as deprecated. If that's the intention I can 
provide a patch to do so hoping [~stack] can still include it in 2.0.
{quote}
My bad. It is typo. The method should be removed in 3.0 is Cell#getTypeByte.
{quote}So we remove both #getTypeByte and #getType in 3.0?
{quote}
Only Cell#getTypeByte will be removed in 3.0


was (Author: chia7712):
{quote}In that case we'd need to deprecate `Cell#getType()` in 2.0 but that has 
not happened. It's not marked as deprecated. If that's the intention I can 
provide a patch to do so hoping [~stack] can still include it in 2.0.
{quote}
My bad. It is typo. The method should be removed in 3.0 is Cell#getTypeByte.

> Add default impl to Cell#getType
> --------------------------------
>
>                 Key: HBASE-19746
>                 URL: https://issues.apache.org/jira/browse/HBASE-19746
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Chia-Ping Tsai
>            Assignee: Chia-Ping Tsai
>            Priority: Critical
>             Fix For: 2.0.0
>
>         Attachments: HBASE-19746.v0.patch, HBASE-19746.v1.patch, 
> HBASE-19746.v1.qa.patch
>
>
> Noticed this issue when migrating the app to branch-2.
> {{Cell}} is IA.Public so it should obey our compatibility rules. Not sure 
> whether any related discussion had be in HBASE-19112. It worthwhile, however, 
> to raise this issue again.
> FYI [~anoopsamjohn] [~ram_krish] [~stack]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to