[
https://issues.apache.org/jira/browse/HBASE-19746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16447248#comment-16447248
]
Lars Francke commented on HBASE-19746:
--------------------------------------
Sorry, I didn't make myself clear.
I'm not advocating removing getTypeByte for 2.0, this one can go in 3.0. We're
both agreeing on that one :)
I'm advocating removing the default implementation of getType for 2.0.
Basically reverting this patch and instead implementing getType in all the Cell
implementations.
I know this is anecdotal (just like yours I assume?) but I haven't seen a
single customer who's implemented their own version of Cell but I agree with
your reasoning.
That said: If I understand this correctly then all we're disagreeing on is
whether we want to break BC from 1 -> 2 or from 2 ->3. In my opinion it should
be sooner rather than later and if I understand you correctly you'd rather do
it later and leave the default implementation in there.
My reasoning for doing it sooner rather than later is that we have no way to
add a compile-time warning that warns of the impeding removal of the default
implementation. To be honest I have no idea how to proceed.
What we do agree on is that the Javadoc for getType needs to be clarified,
right?
> Add default impl to Cell#getType
> --------------------------------
>
> Key: HBASE-19746
> URL: https://issues.apache.org/jira/browse/HBASE-19746
> Project: HBase
> Issue Type: Sub-task
> Reporter: Chia-Ping Tsai
> Assignee: Chia-Ping Tsai
> Priority: Critical
> Fix For: 2.0.0
>
> Attachments: HBASE-19746.v0.patch, HBASE-19746.v1.patch,
> HBASE-19746.v1.qa.patch
>
>
> Noticed this issue when migrating the app to branch-2.
> {{Cell}} is IA.Public so it should obey our compatibility rules. Not sure
> whether any related discussion had be in HBASE-19112. It worthwhile, however,
> to raise this issue again.
> FYI [~anoopsamjohn] [~ram_krish] [~stack]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
