[
https://issues.apache.org/jira/browse/HBASE-20456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16448131#comment-16448131
]
Duo Zhang commented on HBASE-20456:
-----------------------------------
Discussed with [~zghaobac] again, the difficulty here is that, we assume that
in DA state a region will not use the special WAL for sync replication peer, so
when removing the peer we need to do nothing. So if we always use a special WAL
then after removing the peer, the WAL is still there... And also, the wal files
will be added to all replication sources, so even if we remove the peer,
replication sources for other peers will still create a shipper for it.
Another way maybe use the same group which we use in DA or S state, but we
could also use multiwal, then we can not know the group unless we actual get a
WAL instance... This is a bit ugly... We get a WAL using the old WALProvider,
and then drop it and create our own WAL...
> Support removing a ReplicationSourceShipper for a special wal group
> -------------------------------------------------------------------
>
> Key: HBASE-20456
> URL: https://issues.apache.org/jira/browse/HBASE-20456
> Project: HBase
> Issue Type: Sub-task
> Components: Replication, wal
> Reporter: Duo Zhang
> Assignee: Duo Zhang
> Priority: Major
> Fix For: HBASE-19064
>
> Attachments: HBASE-20456-HBASE-19064-v1.patch,
> HBASE-20456-HBASE-19064-v2.patch, HBASE-20456-HBASE-19064-v3.patch,
> HBASE-20456-HBASE-19064.patch
>
>
> For the multi wal implementation, if a new group is created, then we will
> always open a wal writer for it, even if no one uses it later. But for sync
> replication, if the peer is transited to DA or S from A, the special wal will
> be closed and there will be no more wal files for it so we need to close the
> shipper
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
