[ https://issues.apache.org/jira/browse/HBASE-20468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16449138#comment-16449138 ]
Hadoop QA commented on HBASE-20468: ----------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s{color} | {color:blue} Docker mode activated. {color} | | {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 4s{color} | {color:red} HBASE-20468 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/0.7.0/precommit-patchnames for help. {color} | \\ \\ || Subsystem || Report/Notes || | JIRA Issue | HBASE-20468 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12920382/HBASE-20468.001.patch | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/12608/console | | Powered by | Apache Yetus 0.7.0 http://yetus.apache.org | This message was automatically generated. > RPC quota requests ineffective due to not counting multi-actions > ---------------------------------------------------------------- > > Key: HBASE-20468 > URL: https://issues.apache.org/jira/browse/HBASE-20468 > Project: HBase > Issue Type: Bug > Components: rpc > Reporter: Josh Elser > Assignee: Josh Elser > Priority: Critical > Fix For: 2.1.0, 1.5.0, 1.3.3, 1.2.8, 2.0.1, 1.4.5 > > Attachments: HBASE-20468.001.patch > > > Was digging into a problem with [~ankit.singhal] where setting RPC quotas on > number of requests wasn't having any effect on a multi-Get > Ankit did enough digging to find that this was because each RPC was being > treated as one request instead of the number of requests contained within the > RPC itself. > Thinking as an operator, this is a pretty ineffective control because a user > could just craft their API usage easily to work around any kind of limits I > want to set to control their impact on the system. TimeBasedLimiter is > assuming that one call to the quota code can only count as one request which > I think is just wrong. -- This message was sent by Atlassian JIRA (v7.6.3#76005)