[
https://issues.apache.org/jira/browse/HBASE-20478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452345#comment-16452345
]
Mike Drob commented on HBASE-20478:
-----------------------------------
The hadoop annotations and jackson 1 imports can definitely go into checkstyle.
I did jackson via anti because I didn't know about checkstyle banned imports at
the time.
The logging stuff, maybe we still do need it places, but we can add it to
checkstyle anyway and then filter the imports with
http://checkstyle.sourceforge.net/config_filters.html#SuppressWithNearbyCommentFilter
where we really need them
> precommit check for "hbase antipatterns" should log details and add a footer
> as needed
> --------------------------------------------------------------------------------------
>
> Key: HBASE-20478
> URL: https://issues.apache.org/jira/browse/HBASE-20478
> Project: HBase
> Issue Type: Improvement
> Components: test
> Reporter: Sean Busbey
> Assignee: Sean Busbey
> Priority: Major
> Attachments: HBASE-20478.0.patch, HBASE-20478.1.patch,
> HBASE-20478.2.patch, HBASE-20478.WIP.2.patch, HBASE-20478.WIP.2.patch,
> HBASE-20478.WIP.patch
>
>
> came up in discussion on HBASE-20332. our check of "don't do this" things in
> the codebase doesn't log the specifics of complaints anywhere, which forces
> those who want to follow up to reverse engineer the check.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
