[ 
https://issues.apache.org/jira/browse/HBASE-20476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16456188#comment-16456188
 ] 

Duo Zhang commented on HBASE-20476:
-----------------------------------

OK, skimmed the code, seems the zero is from here.

{code}
  void checkOnlineRegionsReport(final ServerStateNode serverNode, final 
Set<byte[]> regionNames)
      throws YouAreDeadException {
    ...
            } else if (regionNode.isInState(State.OPENING)) {
              try {
                if (!reportTransition(regionNode, serverNode, 
TransitionCode.OPENED, 0)) {
                  LOG.warn(regionNode.toString() + " reported OPEN on server=" 
+ serverName +
                    " but state has otherwise AND NO procedure is running");
                }
              } catch (UnexpectedStateException e) {
                LOG.warn(regionNode.toString() + " reported unexpteced OPEN: " 
+ e.getMessage(), e);
              }
            }
    ...
  }
{code}

It is called in regionServerReport. I think the intention here is to check 
whether the region has actually been opened on that RS. So a simple break is OK 
I think. As we should have already called reportRegionStateTransition before 
adding the region to our opened region map at RS side.

> Fix the flaky TestReplicationSmallTests unit test
> -------------------------------------------------
>
>                 Key: HBASE-20476
>                 URL: https://issues.apache.org/jira/browse/HBASE-20476
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Zheng Hu
>            Assignee: Duo Zhang
>            Priority: Major
>         Attachments: HBASE-20476-addlog.patch, HBASE-20476.patch
>
>
> See 
> https://builds.apache.org/job/HBASE-Find-Flaky-Tests/lastSuccessfulBuild/artifact/dashboard.html



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to