[ 
https://issues.apache.org/jira/browse/HBASE-20497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16457490#comment-16457490
 ] 

Duo Zhang commented on HBASE-20497:
-----------------------------------

{code}
-  Server getServer() {
+  @VisibleForTesting
+  public Server getServer() {
     return server;
   }
{code}

This is not VisibleForTesting? We call it in RecoveredReplicationSourceShipper.

Overall LGTM. +1.

> The getRecoveredQueueStartPos always return 0 in 
> RecoveredReplicationSourceShipper
> ----------------------------------------------------------------------------------
>
>                 Key: HBASE-20497
>                 URL: https://issues.apache.org/jira/browse/HBASE-20497
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 2.1.0
>            Reporter: Zheng Hu
>            Assignee: Zheng Hu
>            Priority: Major
>             Fix For: 3.0.0, 2.1.0
>
>         Attachments: HBASE-20497.v1.patch
>
>
> See 
> https://issues.apache.org/jira/browse/HBASE-20475?page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel&focusedCommentId=16454240#comment-16454240



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to