[
https://issues.apache.org/jira/browse/HBASE-20500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16457585#comment-16457585
]
Ted Yu commented on HBASE-20500:
--------------------------------
For the new test, please add the following at the end of the method:
{code}
LOG.info("Remove group "+fooGroup.getName());
rsGroupAdmin.removeRSGroup(fooGroup.getName());
{code}
Otherwise the foo group would stay, potentially interfering with subsequent
tests since we have no control over the order of subtests.
{code}
if (RSGroupInfo.DEFAULT_GROUP.equals(srcGrp.getName())) {
checkOnlineServersOnly(servers);
}
+
+ if (RSGroupInfo.DEFAULT_GROUP.equals(srcGrp.getName()) &&
srcGrp.getServers().size() <=
+ servers.size()) {
{code}
As you can see, the new condition can actually be moved to under the condition
directly above it.
It would be easier to read.
I ran TestRSGroups with patch v2 locally and it passed.
Once the above comments are addressed, I will integrate.
Thanks
> [rsgroup] should keep at least one server in default group
> ----------------------------------------------------------
>
> Key: HBASE-20500
> URL: https://issues.apache.org/jira/browse/HBASE-20500
> Project: HBase
> Issue Type: Bug
> Components: rsgroup
> Affects Versions: 2.0.0-beta-2
> Reporter: Yechao Chen
> Assignee: Yechao Chen
> Priority: Major
> Attachments: HBASE-20500-branch-2.v1.patch,
> HBASE-20500-master.v1.patch, HBASE-20500-master.v2.patch
>
>
> we move all the servers from default group
> the default group will has no servers,
> then we create a new table ,
> it will failed case of the default group has no servers
> eorr info is :
> EROOR: ConstraintException:Target RSGroup must have at lease on server
>
> we should keep at least one server in 'default' RSGroup
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
