[ 
https://issues.apache.org/jira/browse/HBASE-20509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16458420#comment-16458420
 ] 

taiyinglee commented on HBASE-20509:
------------------------------------

yes

> putting List in HashSet directly without using addAll function to improve 
> performance
> -------------------------------------------------------------------------------------
>
>                 Key: HBASE-20509
>                 URL: https://issues.apache.org/jira/browse/HBASE-20509
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 3.0.0
>            Reporter: taiyinglee
>            Priority: Trivial
>
> [https://docs.oracle.com/javase/7/docs/api/java/util/Collection.html]
> change
> Set<ServerName> serverSet = new HashSet<>();
>  serverSet.addAll(serverList);
> to
> Set<ServerName> serverSet = new HashSet<>(serverList);
> in
> ./hbase-server/src/main/java/org/apache/hadoop/hbase/favored/FavoredNodeAssignmentHelper.java
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to