[ 
https://issues.apache.org/jira/browse/HBASE-5332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13211050#comment-13211050
 ] 

Phabricator commented on HBASE-5332:
------------------------------------

Kannan has commented on the revision "[jira] [HBASE-5332] Deterministic 
Compaction Jitter".

INLINE COMMENTS
  src/main/java/org/apache/hadoop/hbase/regionserver/Store.java:1067 Also, once 
the read lock is removed, we should assign (snapshot) the immutable list into 
another variable so that the various accesses on it are working on the 
same/consistent view.

  So, something like:

   storefilesSnapShot = this.storefiles;
   if (storefilesSnapshot != null && !storefilesSnapshot.isEmpty()) {
        ... storefilesSnapshot.get(0)....
   }


REVISION DETAIL
  https://reviews.facebook.net/D1785

                
> Deterministic Compaction Jitter
> -------------------------------
>
>                 Key: HBASE-5332
>                 URL: https://issues.apache.org/jira/browse/HBASE-5332
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Nicolas Spiegelberg
>            Assignee: Nicolas Spiegelberg
>            Priority: Minor
>         Attachments: D1785.1.patch, D1785.2.patch
>
>
> Currently, we add jitter to a compaction using "delay + jitter*(1 - 
> 2*Math.random())".  Since this is non-deterministic, we can get major 
> compaction storms on server restart as half the Stores that were set to 
> "delay + jitter" will now be set to "delay - jitter".  We need a more 
> deterministic way to jitter major compactions so this information can persist 
> across server restarts.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to