[ 
https://issues.apache.org/jira/browse/HBASE-20524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16462125#comment-16462125
 ] 

Guanghao Zhang commented on HBASE-20524:
----------------------------------------

Checked all methods which call removeRecoveredSource or removeSource will call 
terminate first. So move clear metrics to terminate method. But there was a 
special case for RevoeredReplicationSource. It will call removeRecoveredSource 
in tryFinish method. So clear metrics in this method, too.

> Need to clear metrics when ReplicationSourceManager refresh replication 
> sources
> -------------------------------------------------------------------------------
>
>                 Key: HBASE-20524
>                 URL: https://issues.apache.org/jira/browse/HBASE-20524
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Guanghao Zhang
>            Assignee: Guanghao Zhang
>            Priority: Minor
>
> When ReplicationSourceManager refresh replication sources, it will close the 
> old source first, then startup a new source. The new source will use a new 
> metrics, but forgot to clear the metrics for old sources.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to