[ 
https://issues.apache.org/jira/browse/HBASE-20528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16463989#comment-16463989
 ] 

Chia-Ping Tsai commented on HBASE-20528:
----------------------------------------

There are some rules to the patch. Please take a look at 
[doc|https://hbase.apache.org/book.html#submitting.patches]
{code:java}
curFunctionCosts[i] = tempFunctionCosts[i];{code}
I grep the above keyword, and then get two results in StochasticLoadBalancer. 
Could you fix both of them?

> Revise collections copying from iteration to built-in function
> --------------------------------------------------------------
>
>                 Key: HBASE-20528
>                 URL: https://issues.apache.org/jira/browse/HBASE-20528
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 3.0.0
>            Reporter: Hua-Yi Ho
>            Assignee: Hua-Yi Ho
>            Priority: Minor
>             Fix For: 3.0.0
>
>         Attachments: 
> 0001-Revise-collections-copying-to-built-in-function.patch
>
>
> Some collection codes in file
> StochasticLoadBalancer.java, AbstractHBaseTool.java, HFileInputFormat.java, 
> Result.java, and WalPlayer.java, using iterations to copy whole data in 
> collections. The iterations can just replace by just Colletions.addAll and 
> Arrays.copyOf.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to