[
https://issues.apache.org/jira/browse/HBASE-18812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16470090#comment-16470090
]
Guangxu Cheng commented on HBASE-18812:
---------------------------------------
Thank [~chia7712] for your patience review.:)
||Class||scope||
|HBaseFsck|LimitedPrivate|
|WALPrettyPrinter|LimitedPrivate|
|HFilePrettyPrinter|LimitedPrivate|
|ZKMainServer|LimitedPrivate|
|HMaster|LimitedPrivate|
|HRegionServer|LimitedPrivate|
|thrift.ThriftServer|LimitedPrivate|
|thrift2.ThriftServer|LimitedPrivate|
|RESTServer|LimitedPrivate|
|HQuorumPeer|LimitedPrivate|
|MapreduceDependencyClasspathTool|LimitedPrivate|
|PerformanceEvaluation|LimitedPrivate|
|LoadTestTool|LimitedPrivate|
|BackupDriver|Private|
|RestoreDriver|Private|
|CreateSnapshot|Private|
|Canary|Private|
|RegionSplitter|Private|
|HBaseConfTool|Private|
|ZkAclReset|Private|
|SnapshotInfo|Public|
|ExportSnapshot|Public|
|VersionInfo|Public|
|RowCounter|Public|
|CellCounter|Public|
1. The classes listed above are used by shell. About 12 classes are not made as
LimitedPrivate.TOOLS.
However, 5 classes are made as Public. Should we change these classes's
InterfaceAudience from Public to LP?
||Class||scope||
|ReplicationSyncUp|Private|
|WALPerformanceEvaluation|Private|
|DumpReplicationQueues|Private|
|Compressor|Private|
2. And 4 classes are documented.
> Recategorize some of classes used as tools
> ------------------------------------------
>
> Key: HBASE-18812
> URL: https://issues.apache.org/jira/browse/HBASE-18812
> Project: HBase
> Issue Type: Task
> Reporter: Chia-Ping Tsai
> Assignee: Guangxu Cheng
> Priority: Major
> Attachments: HBASE-18812.master.001.patch,
> HBASE-18812.master.002.patch
>
>
> The classes used from cmd line should be made as LimitedPrivate.TOOLS. The
> candidates are shown below.
> # BackupDriver
> # RestoreDriver
> # CreateSnapshot
> # SnapshotInfo
> # ExportSnapshot
> # Canary
> # VersionInfo
> # RegionMover
> # CellCounter
> # CopyTable
> # DumpReplicationQueues
> # Export
> # HashTable
> # Import
> # ImportTsv
> # LoadIncrementalHFiles
> # ReplicationSyncUp
> # SyncTable
> # VerifyReplication
> # WALPlayer
> # ZkAclReset
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
