[
https://issues.apache.org/jira/browse/HBASE-20520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16471187#comment-16471187
]
Mike Drob commented on HBASE-20520:
-----------------------------------
Left a minor nit on RB, otherwise patch looks good. +1 to commit it, sir.
> Failed effort upping default HDFS blocksize, hbase.regionserver.hlog.blocksize
> ------------------------------------------------------------------------------
>
> Key: HBASE-20520
> URL: https://issues.apache.org/jira/browse/HBASE-20520
> Project: HBase
> Issue Type: Sub-task
> Components: conf
> Reporter: stack
> Assignee: stack
> Priority: Major
> Fix For: 2.0.1
>
> Attachments: HBASE-20520.branch-2.0.001.patch,
> HBASE-20520.branch-2.0.002.patch, HBASE-20520.branch-2.0.003.patch,
> HBASE-20520.branch-2.0.004.patch, HBASE-20520.branch-2.0.005.patch
>
>
> Good one found by our [~mdrob]. Problem in the parent issue where failed
> attempt doubling default block size but halving the size at which roll -- so
> we end up in roughly same place only we make less small WALs in those cases
> where we are writing furiously and fail to roll before starting a new block.
> From Drob: ".../we drop default log roll to 0.5, but we don't actually
> increase the block size... AbstractProtobufLogWriter.java:164 still uses
> default HDFS block sizing and AbstractFSWAL.java:408 block size is only used
> in a log message, never actually makes it to files...".
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
