[
https://issues.apache.org/jira/browse/HBASE-20577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16474500#comment-16474500
]
Nihal Jain commented on HBASE-20577:
------------------------------------
{quote}Would the new patch serve the old purpose (i.e.g changing log level from
command line)?
{quote}
Hi [~jojochuang], I have tested the command line log level tool, it works
perfectly fine as there is no change in the patch with regards to the
processing logic. Attaching a screenshot of the same. Also, the test cases in
{{org.apache.hadoop.hbase.http.log.TestLogLevel}} will ensure that CLI
functionality does not break.
I understand your concern, but this patch is simply an attempt to make hbase UI
consistent across various pages.
> Make Log Level page design consistent with the design of other pages in UI
> --------------------------------------------------------------------------
>
> Key: HBASE-20577
> URL: https://issues.apache.org/jira/browse/HBASE-20577
> Project: HBase
> Issue Type: Improvement
> Components: UI, Usability
> Reporter: Nihal Jain
> Assignee: Nihal Jain
> Priority: Major
> Fix For: 3.0.0
>
> Attachments: HBASE-20577.master.001.patch,
> after_patch_get_log_level.png, after_patch_require_field_validation.png,
> after_patch_set_log_level_bad.png, after_patch_set_log_level_success.png,
> before_patch_no_validation_required_field.png
>
>
> The Log Level page in web UI seems out of the place. I think we should make
> it look consistent with design of other pages in HBase web UI.
> Also, validation of required fields should be done, otherwise user should not
> be allowed to click submit button.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)