[
https://issues.apache.org/jira/browse/HBASE-20576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16475344#comment-16475344
]
Duo Zhang commented on HBASE-20576:
-----------------------------------
{quote}
If pass an invalid path which has no schema (such as,
REMOTE_WAL_DIR=>'/hbase/remoteWALs' ), the remoteWALDirForPeer.getFileSystem
will use the default Fs in env.getMasterConfiguration(), which is incorrect ...
Better to check the path when both peer adding & transiting.
{quote}
Then we need to change the title of this issue. And when transiting we just
need to check the existence, on adding maybe we could add a check to make sure
that the path is a fully qualified path.
{quote}
BTW, can just use remoteWALDirForPeer , instead of
remoteWALDirForPeer.toUri().toString() in
{quote}
Just want to make sure that we print out the fully qualified path.
{quote}
Here the SupressWarning annotation could be removed ?
{quote}
There is a warning: 'Type safety: A generic array of
Procedure<MasterProcedureEnv> is created for a varargs parameter'.
> Check whether the remote WAL directory is provided when transiting to A
> -----------------------------------------------------------------------
>
> Key: HBASE-20576
> URL: https://issues.apache.org/jira/browse/HBASE-20576
> Project: HBase
> Issue Type: Sub-task
> Components: Replication
> Reporter: Duo Zhang
> Assignee: Duo Zhang
> Priority: Major
> Fix For: HBASE-19064
>
> Attachments: HBASE-20576-HBASE-19064-v1.patch,
> HBASE-20576-HBASE-19064-v1.patch, HBASE-20576-HBASE-19064-v1.patch,
> HBASE-20576-HBASE-19064.patch, HBASE-20576-HBASE-19064.patch
>
>
> When testing on the real cluster I typed a wrong remote wal directory. Then I
> start the procedure for transiting the peer to A, the procedure was stuck
> there for ever...
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
