Andrew Purtell commented on HBASE-19722:

Latest patch looks much better.

This looks like a typo:

Do you think {{getTableNameFromOp}}, {{getRegionIdFromOp}}, and 
{{isMetaTableOp}} are generally useful and should go into the client API as 
static helper methods? They look useful. Is Object the common base class or is 
there something higher up in the hierarchy that is still common like 
{{Operation}}? (Just a thought, I didn't look.)

When using the String constructors to make strings from byte[] should specify a 
charset. We use UTF_8 throughout HBase.

I'm a little concerned about the allocation demand of tracking every client, of 
perhaps many thousands, instead of top-N. However trying to do top-N would be 
complicated. We'd need to keep all the state to do top-N around and frequently 
clean up stale entries when the set of top-N changes. So I think all of that 
can be deferred until later. We can try this out as is first. 

> Implement a meta query statistics metrics source
> ------------------------------------------------
>                 Key: HBASE-19722
>                 URL: https://issues.apache.org/jira/browse/HBASE-19722
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Andrew Purtell
>            Assignee: Xu Cang
>            Priority: Major
>         Attachments: HBASE-19722.branch-1.v001.patch, 
> HBASE-19722.master.010.patch
> Implement a meta query statistics metrics source, created whenever a 
> regionserver starts hosting meta, removed when meta hosting moves. Provide 
> views on top tables by request counts, top meta rowkeys by request count, top 
> clients making requests by their hostname. 
> Can be implemented as a coprocessor.

This message was sent by Atlassian JIRA

Reply via email to