[
https://issues.apache.org/jira/browse/HBASE-20556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16479980#comment-16479980
]
Tak Lon (Stephen) Wu edited comment on HBASE-20556 at 5/21/18 6:22 PM:
-----------------------------------------------------------------------
I submitted another patch for fixing the
[checkstyle|https://builds.apache.org/job/PreCommit-HBASE-Build/12854/artifact/patchprocess/diff-checkstyle-hbase-server.txt]
failure, however, I found the failures in
[complie|https://builds.apache.org/job/PreCommit-HBASE-Build/12854/artifact/patchprocess/patch-compile-hbase-server-jdk1.7.0_181.txt]
and
[unit|https://builds.apache.org/job/PreCommit-HBASE-Build/12854/artifact/patchprocess/patch-unit-hbase-server.txt]
logs should not be related.
* [updated] in
[complie|https://builds.apache.org/job/PreCommit-HBASE-Build/12854/artifact/patchprocess/patch-compile-hbase-server-jdk1.7.0_181.txt]
logs, there is an jdk 7 incompatible with jdk 8 of
`maven-compiler-plugin:3.6.1:compile: java.lang.UnsupportedClassVersionError:
javax/tools/DiagnosticListener : Unsupported major.minor version 52.0`. I found
that HBASE-12350 brought ```-PerrorProne``` that does not competible with jdk7,
so if we can remove ```-PerrorProne``` from the mvn compile command, it passed
(see the command below). *Opened HBASE-20608 for this issue.*
{code:java}
mvn -Dmaven.repo.local=<repo path> -DHBasePatchProcess clean test-compile
-DskipTests=true{code}
* in
[unit|https://builds.apache.org/job/PreCommit-HBASE-Build/12854/artifact/patchprocess/patch-unit-hbase-server.txt]
log, all unit tests completed but at the end of the test process, I saw a lots
of `ExecutionException The forked VM terminated without properly saying
goodbye. VM crash or System.exit called?` I found this [surefire
faq|http://maven.apache.org/surefire/maven-surefire-plugin/faq.html] and said
system.exit() at any time is not supported (I also found some other JIRAs that
works on branch-1 has this issue). So those Test classes called system.exit()
should not be related to this change, but just be curious, does anyone know how
to get it thru? I locally tried to add more memory to the surefire plugin
`-Dsurefire.Xmx=4000m` then I saw an different error message. [~apurtell]
(apologized for pinging you directly) do you have idea for the error I
mentioned here ?
was (Author: taklwu):
I submitted another patch for fixing the
[checkstyle|https://builds.apache.org/job/PreCommit-HBASE-Build/12854/artifact/patchprocess/diff-checkstyle-hbase-server.txt]
failure, however, I found the failures in
[complie|https://builds.apache.org/job/PreCommit-HBASE-Build/12854/artifact/patchprocess/patch-compile-hbase-server-jdk1.7.0_181.txt]
and
[unit|https://builds.apache.org/job/PreCommit-HBASE-Build/12854/artifact/patchprocess/patch-unit-hbase-server.txt]
logs should not be related.
* [updated] in
[complie|https://builds.apache.org/job/PreCommit-HBASE-Build/12854/artifact/patchprocess/patch-compile-hbase-server-jdk1.7.0_181.txt]
logs, there is an jdk 7 incompatible with jdk 8 of
`maven-compiler-plugin:3.6.1:compile: java.lang.UnsupportedClassVersionError:
javax/tools/DiagnosticListener : Unsupported major.minor version 52.0`. I found
that HBASE-12350 brought ```-PerrorProne``` that does not competible with jdk7,
so if we can remove ```-PerrorProne``` from the mvn compile command, it passed
(see the command below). *How can we open a Jira for changing jdk7's mvn
compile in Jenkins build script ? or should I send email to dev email list ?*
{code:java}
mvn -Dmaven.repo.local=<repo path> -DHBasePatchProcess clean test-compile
-DskipTests=true{code}
* in
[unit|https://builds.apache.org/job/PreCommit-HBASE-Build/12854/artifact/patchprocess/patch-unit-hbase-server.txt]
log, all unit tests completed but at the end of the test process, I saw a lots
of `ExecutionException The forked VM terminated without properly saying
goodbye. VM crash or System.exit called?` I found this [surefire
faq|http://maven.apache.org/surefire/maven-surefire-plugin/faq.html] and said
system.exit() at any time is not supported (I also found some other JIRAs that
works on branch-1 has this issue). So those Test classes called system.exit()
should not be related to this change, but just be curious, does anyone know how
to get it thru? I locally tried to add more memory to the surefire plugin
`-Dsurefire.Xmx=4000m` then I saw an different error message. [~apurtell]
(apologized for pinging you directly) do you have idea for the error I
mentioned here ?
> Backport HBASE-16490 to branch-1
> --------------------------------
>
> Key: HBASE-20556
> URL: https://issues.apache.org/jira/browse/HBASE-20556
> Project: HBase
> Issue Type: Sub-task
> Components: HFile, snapshots
> Affects Versions: 1.4.4, 1.4.5
> Reporter: Tak Lon (Stephen) Wu
> Assignee: Tak Lon (Stephen) Wu
> Priority: Major
> Attachments: HBASE-20556.branch-1.001.patch,
> HBASE-20556.branch-1.002.patch, HBASE-20556.branch-1.003.patch
>
>
> As part of HBASE-20555, HBASE-16490 is the first patch that is needed for
> backporting HBASE-18083
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
