[ 
https://issues.apache.org/jira/browse/HBASE-20615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16484641#comment-16484641
 ] 

Sean Busbey commented on HBASE-20615:
-------------------------------------

bq.  -1 hbaseanti       0m 0s   The patch appears use HTrace 3 classes instead 
of HTrace 4.

This is matching the added test from the commit for HBASE-20332. will address 
on that jira.

bq. -1  whitespace      0m 0s   The patch has 1 line(s) that end in whitespace. 
Use git apply --whitespace=fix <<patch_file>>. Refer 
https://git-scm.com/docs/git-apply

This is from the commit for HBASE-20333. will address on that jira.


> include shaded artifacts in binary install
> ------------------------------------------
>
>                 Key: HBASE-20615
>                 URL: https://issues.apache.org/jira/browse/HBASE-20615
>             Project: HBase
>          Issue Type: Sub-task
>          Components: build, Client, Usability
>    Affects Versions: 2.0.0
>            Reporter: Sean Busbey
>            Assignee: Sean Busbey
>            Priority: Major
>             Fix For: 3.0.0, 2.1.0
>
>         Attachments: HBASE-20615.0.patch
>
>
> Working through setting up an IT for our shaded artifacts in HBASE-20334 
> makes our lack of packaging seem like an oversight. While I could work around 
> by pulling the shaded clients out of whatever build process built the 
> convenience binary that we're trying to test, it seems v awkward.
> After reflecting on it more, it makes more sense to me for there to be a 
> common place in the install that folks running jobs against the cluster can 
> rely on. If they need to run without a full hbase install, that should still 
> work fine via e.g. grabbing from the maven repo.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to