[
https://issues.apache.org/jira/browse/HBASE-5357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13213246#comment-13213246
]
Phabricator commented on HBASE-5357:
------------------------------------
tedyu has commented on the revision "[jira] [HBASE-5357] Refactoring: use the
builder pattern for HColumnDescriptor".
Patch looks good.
INLINE COMMENTS
src/main/java/org/apache/hadoop/hbase/HTableDescriptor.java:1119 Do we need
10 versions for -ROOT- table ?
src/main/java/org/apache/hadoop/hbase/HTableDescriptor.java:1131 Do we need
10 versions for .META. table ?
REVISION DETAIL
https://reviews.facebook.net/D1851
> Use builder pattern in HColumnDescriptor
> ----------------------------------------
>
> Key: HBASE-5357
> URL: https://issues.apache.org/jira/browse/HBASE-5357
> Project: HBase
> Issue Type: Improvement
> Reporter: Mikhail Bautin
> Assignee: Mikhail Bautin
> Attachments: D1851.1.patch,
> Use-builder-pattern-for-HColumnDescriptor-2012-02-21_19_13_35.patch
>
>
> We have five ways to create an HFile writer, two ways to create a StoreFile
> writer, and the sets of parameters keep changing, creating a lot of
> confusion, especially when porting patches across branches. The same thing is
> happening to HColumnDescriptor. I think we should move to a "builder pattern"
> solution, e.g.
> {code:java}
> HFileWriter w = HFile.getWriterBuilder(conf, <some common args>)
> .setParameter1(value1)
> .setParameter2(value2)
> ...
> .build();
> {code}
> Each parameter setter being on its own line will make merges/cherry-pick work
> properly, we will not have to even mention default parameters again, and we
> can eliminate a dozen impossible-to-remember constructors.
> This particular JIRA addresses the HColumnDescriptor refactoring. For
> StoreFile/HFile refactoring see HBASE-5442.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
