[
https://issues.apache.org/jira/browse/HBASE-20639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16492026#comment-16492026
]
Nihal Jain commented on HBASE-20639:
------------------------------------
{quote}I think a new test class should be created in hbase-rsgroup module.
{quote}
I think the tests can be accomodated in {{TestRSGroupsWithACL}}, in fact older
tests need a slight modification. Though we had a missing testÂ
{{testRemoveServers}}. I have taken care of it.
{quote}Refer to HBASE-20624 for the pre-hooks where permission checking should
be done.
{quote}
Yes, I think you're referring to HBASE-20627 . Right?
I have submitted a patch. Please review!
> Implement permission checking through AccessController instead of
> RSGroupAdminEndpoint
> --------------------------------------------------------------------------------------
>
> Key: HBASE-20639
> URL: https://issues.apache.org/jira/browse/HBASE-20639
> Project: HBase
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Nihal Jain
> Priority: Major
> Attachments: HBASE-20639.master.001.patch
>
>
> Currently permission checking for various RS group operations is done via
> RSGroupAdminEndpoint.
> e.g. in RSGroupAdminServiceImpl#moveServers() :
> {code}
> checkPermission("moveServers");
> groupAdminServer.moveServers(hostPorts, request.getTargetGroup());
> {code}
> The practice in remaining parts of hbase is to perform permission checking
> within AccessController.
> Now that observer hooks for RS group operations are in right place, we should
> follow best practice and move permission checking to AccessController.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
