[ 
https://issues.apache.org/jira/browse/HBASE-20653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16492894#comment-16492894
 ] 

Ted Yu commented on HBASE-20653:
--------------------------------

bq.  method checkPermission in RSGroupAdminEndpoint which becomes redundant

Since permission checking is not done in RSGroupAdminEndpoint, the method 
should be removed.

Other than that, patch looks good.

> Add missing observer hooks for region server group to MasterObserver
> --------------------------------------------------------------------
>
>                 Key: HBASE-20653
>                 URL: https://issues.apache.org/jira/browse/HBASE-20653
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Nihal Jain
>            Priority: Major
>             Fix For: 3.0.0
>
>         Attachments: HBASE-20653.master.001.patch
>
>
> Currently the following region server group operations don't have 
> corresponding hook in MasterObserver :
> * getRSGroupInfo
> * getRSGroupInfoOfServer
> * getRSGroupInfoOfTable
> * listRSGroup
> This JIRA is to 
> * add them to MasterObserver
> * add corresponding permission check in AccessController
> * move the {{checkPermission}} out of RSGroupAdminEndpoint
> * add corresponding tests to TestRSGroupsWithACL



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to