[
https://issues.apache.org/jira/browse/HBASE-20631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16495936#comment-16495936
]
Ted Yu commented on HBASE-20631:
--------------------------------
{code}
-import static
org.apache.hadoop.hbase.backup.BackupRestoreConstants.OPTION_PATH;
{code}
The old option is no longer supported ?
{code}
import static
org.apache.hadoop.hbase.backup.BackupRestoreConstants.OPTION_PATH_DESC;
{code}
OPTION_PATH_DESC -> OPTION_PATH_PURGE_DESC
{code}
+ } catch(NumberFormatException e) {
+ throw new IOException(value + " is not a number");
{code}
number -> integer
{code}
+ final int fdays = days;
{code}
Why not declaring fdays as long directly ?
{code}
+ System.out.println("Deleted " + deleted + " backups. Total older than "
+ + days +" days: " + backupIds.length);
{code}
If the number of deleted backups is lower than backupIds.length, what may be
the cause ?
{code}
+ public void testBackupDeleteDatePurgeCommand() throws Exception {
{code}
The 'Delete' and 'purge' are redundant in the test name.
> B&R: Merge command enhancements
> --------------------------------
>
> Key: HBASE-20631
> URL: https://issues.apache.org/jira/browse/HBASE-20631
> Project: HBase
> Issue Type: New Feature
> Reporter: Vladimir Rodionov
> Assignee: Vladimir Rodionov
> Priority: Major
> Attachments: HBASE-20630-v1.patch
>
>
> Currently, merge supports only list of backup ids, which users must provide.
> Date range merges seem more convenient for users.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
