[ 
https://issues.apache.org/jira/browse/HBASE-20669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16498362#comment-16498362
 ] 

Sean Busbey commented on HBASE-20669:
-------------------------------------

+1

bq. 0   findbugs        0m 1s   Findbugs executables are not available.

This is concerning. I'll run it locally. we should track that this is off in a 
jira so it can get fixed.

bq. -1  test4tests      0m 0s   The patch doesn't appear to include any new or 
modified tests. Please justify why no new tests are needed for this patch. Also 
please list what manual steps were performed to verify this patch.

This doesn't fit scope for a new or changed test since it just changes an 
implementation detail and not the outcome.

> [findbugs] autoboxing to parse primitive
> ----------------------------------------
>
>                 Key: HBASE-20669
>                 URL: https://issues.apache.org/jira/browse/HBASE-20669
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 1.3.2, 1.5.0, 1.2.7, 1.4.3
>            Reporter: Sean Busbey
>            Assignee: Wei-Chiu Chuang
>            Priority: Major
>             Fix For: 1.5.0, 1.2.7, 1.3.3, 1.4.5
>
>         Attachments: HBASE-20669.branch-1.002.patch
>
>
> HBASE-18864 introduced a change that's been flagged by findbugs. example on 
> branch-1:
> {quote}
> FindBugs      module:hbase-client
> Boxing/unboxing to parse a primitive 
> org.apache.hadoop.hbase.HColumnDescriptor.setValue(byte[], byte[]) At 
> HColumnDescriptor.java:org.apache.hadoop.hbase.HColumnDescriptor.setValue(byte[],
>  byte[]) At HColumnDescriptor.java:[line 579]
> {quote}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to