[
https://issues.apache.org/jira/browse/HBASE-20681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16502195#comment-16502195
]
Josh Elser commented on HBASE-20681:
------------------------------------
{quote}Ugh. this scope change smells bad. Can we find a different way to get
things included in the specific context where we need it?
{quote}
Setting the scope in dependencyManagement drives me bonkers (spent a good
thirty minutes trying to get the stupid jar included in the tarball because I
assumed the default scope was still {{compile}}). As long as it works, I can
set the scope to be {{compile }}in hbase-assembly (and elsewhere if needed?)
{quote}Do we actually need hamcrest in the shaded artifacts, or is this just a
side effect of the scope change above? Could we filter it out instead of
relocating it?
{quote}
If we expect people to be able to run our IntegrationTest code using the shaded
jars, then yes. I was going under the assumption that was "yes". I think we
could be doing a better job here, but that's a long pole to separate
testing-utility from public API, and then separate dependencies accordingly.
{quote}please either make the name match case insensitive or add a supplemental
info entry that corrects the name for hamcrest. Let's try to keep a single
instance of names here.
{quote}
You got it, boss.
> IntegrationTestDriver fails after HADOOP-15406 due to missing hamcrest-core
> ---------------------------------------------------------------------------
>
> Key: HBASE-20681
> URL: https://issues.apache.org/jira/browse/HBASE-20681
> Project: HBase
> Issue Type: Bug
> Components: integration tests
> Reporter: Romil Choksi
> Assignee: Josh Elser
> Priority: Major
> Fix For: 3.0.0, 2.1.0, 2.0.1
>
> Attachments: HBASE-20681.001.patch, HBASE-20681.002.patch
>
>
> HADOOP-15406 marked mockito and junit as test-only dependencies which, I
> believe, has stopped them from being included in a stock Hadoop classpath.
> Prior, you'd get hamcrest at {{share/hadoop/common/lib/hamcrest-core-1.3.jar}}
> However, we depend on it being there for our junit in hbase-it:
> {noformat}
> [INFO] --- maven-dependency-plugin:3.0.1:tree (default-cli) @ hbase-it ---
> [INFO] org.apache.hbase:hbase-it:jar:2.0.1-SNAPSHOT
> [INFO] +- junit:junit:jar:4.12:test
> [INFO] | \- org.hamcrest:hamcrest-core:jar:1.3:test
> {noformat}
> We need to make sure we include it.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
